Skip to content

Fix disk configuration loading for graphical EFI boot order setup#295

Merged
anujm1 merged 1 commit intoopen-edge-platform:3.0-devfrom
Jkintalix:feature/fix-graphical-boot-order-disk-config
Sep 2, 2025
Merged

Fix disk configuration loading for graphical EFI boot order setup#295
anujm1 merged 1 commit intoopen-edge-platform:3.0-devfrom
Jkintalix:feature/fix-graphical-boot-order-disk-config

Conversation

@Jkintalix
Copy link
Copy Markdown
Contributor

@Jkintalix Jkintalix commented Jul 10, 2025

  • Updated calamaresInstall() to use attended_config.json, return the full
  • configuration, and load the final system config produced by Calamares while
  • ensuring BootType is set. Added logging for selected boot partition and
  • installer execution. terminalUIAttendedInstall() was updated to prioritize
  • Calamares’ config when available, ensuring accurate disk/system setup.

Merge Checklist

All boxes should be checked before merging the PR

  • The changes in the PR have been built and tested
  • [] cgmanifest file has been updated if required
  • Ready to merge

Description

For reference to ITEP-69717: These changes improve the installer’s integration with Calamares. The calamaresInstall() function now loads and returns the complete configuration instead of just an error, switching to attended_config.json and ensuring BootType is set for all system configs. Additional logs were added to make boot partition selection and installer execution clearer. In terminalUIAttendedInstall(), a new variable captures the Calamares config and overrides the terminal-based config when valid, so the installer always prefers the most accurate disk and system configuration

On EMT OS, the graphical installer does not currently set the EFI boot entry after installation, whereas the terminal installer does. This appears to be due to missing steps in the graphical installation process. The PR resolves this by ensuring the EFI boot order is correctly updated once the graphical installation is complete.

Any Newly Introduced Dependencies

No

How Has This Been Tested?

Tested locally.

@Jkintalix Jkintalix requested a review from a team as a code owner July 10, 2025 10:09
@Jkintalix Jkintalix marked this pull request as draft July 10, 2025 10:11
@Jkintalix Jkintalix force-pushed the feature/fix-graphical-boot-order-disk-config branch 4 times, most recently from 04aabf0 to 6ed6fab Compare July 10, 2025 10:38
@Jkintalix Jkintalix marked this pull request as ready for review July 10, 2025 10:39
@Jkintalix Jkintalix force-pushed the feature/fix-graphical-boot-order-disk-config branch 3 times, most recently from 4181662 to 336d78d Compare July 15, 2025 04:52
@Jkintalix Jkintalix requested a review from anujm1 July 17, 2025 05:55
@Jkintalix Jkintalix force-pushed the feature/fix-graphical-boot-order-disk-config branch 3 times, most recently from 86aa9ed to 8eaafa2 Compare July 23, 2025 12:32
@Jkintalix Jkintalix force-pushed the feature/fix-graphical-boot-order-disk-config branch 2 times, most recently from 4e4837d to 97d01c1 Compare August 1, 2025 11:01
@Jkintalix Jkintalix force-pushed the feature/fix-graphical-boot-order-disk-config branch 5 times, most recently from 6d9ded9 to cb0b593 Compare August 13, 2025 06:16
@Jkintalix Jkintalix force-pushed the feature/fix-graphical-boot-order-disk-config branch 7 times, most recently from b4c9cd1 to da18de5 Compare August 28, 2025 10:31
@Jkintalix Jkintalix force-pushed the feature/fix-graphical-boot-order-disk-config branch 2 times, most recently from 51f516d to 50269eb Compare September 2, 2025 07:00
@Jkintalix Jkintalix requested a review from a team as a code owner September 2, 2025 08:00
@Jkintalix Jkintalix force-pushed the feature/fix-graphical-boot-order-disk-config branch from a8c68be to 446ea46 Compare September 2, 2025 08:52
- Updated calamaresInstall() to use attended_config.json, return the full

- configuration, and load the final system config produced by Calamares while

- ensuring BootType is set. Added logging for selected boot partition and

- installer execution. terminalUIAttendedInstall() was updated to prioritize

- Calamares’ config when available, ensuring accurate disk/system setup.

Signed-off-by: kinatli jayanth <jayanthx.kintali@intel.com>
@Jkintalix Jkintalix force-pushed the feature/fix-graphical-boot-order-disk-config branch from 446ea46 to 69dfe50 Compare September 2, 2025 08:55
@anujm1 anujm1 merged commit 235c59d into open-edge-platform:3.0-dev Sep 2, 2025
13 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants