Fix disk configuration loading for graphical EFI boot order setup#295
Merged
anujm1 merged 1 commit intoopen-edge-platform:3.0-devfrom Sep 2, 2025
Conversation
04aabf0 to
6ed6fab
Compare
4181662 to
336d78d
Compare
86aa9ed to
8eaafa2
Compare
4e4837d to
97d01c1
Compare
6d9ded9 to
cb0b593
Compare
b4c9cd1 to
da18de5
Compare
51f516d to
50269eb
Compare
a8c68be to
446ea46
Compare
- Updated calamaresInstall() to use attended_config.json, return the full - configuration, and load the final system config produced by Calamares while - ensuring BootType is set. Added logging for selected boot partition and - installer execution. terminalUIAttendedInstall() was updated to prioritize - Calamares’ config when available, ensuring accurate disk/system setup. Signed-off-by: kinatli jayanth <jayanthx.kintali@intel.com>
446ea46 to
69dfe50
Compare
anujm1
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR
Description
For reference to ITEP-69717: These changes improve the installer’s integration with Calamares. The calamaresInstall() function now loads and returns the complete configuration instead of just an error, switching to attended_config.json and ensuring BootType is set for all system configs. Additional logs were added to make boot partition selection and installer execution clearer. In terminalUIAttendedInstall(), a new variable captures the Calamares config and overrides the terminal-based config when valid, so the installer always prefers the most accurate disk and system configuration
On EMT OS, the graphical installer does not currently set the EFI boot entry after installation, whereas the terminal installer does. This appears to be due to missing steps in the graphical installation process. The PR resolves this by ensuring the EFI boot order is correctly updated once the graphical installation is complete.
Any Newly Introduced Dependencies
No
How Has This Been Tested?
Tested locally.