[3.0] toolkit golang version to go1.24.12#704
Merged
cheeyanglee merged 7 commits intoopen-edge-platform:3.0-devfrom Jan 30, 2026
Merged
[3.0] toolkit golang version to go1.24.12#704cheeyanglee merged 7 commits intoopen-edge-platform:3.0-devfrom
cheeyanglee merged 7 commits intoopen-edge-platform:3.0-devfrom
Conversation
Bumps the go_modules group with 1 update in the /toolkit/tools directory: [golang.org/x/crypto](https://github.com/golang/crypto). Updates `golang.org/x/crypto` from 0.36.0 to 0.45.0 - [Commits](golang/crypto@v0.36.0...v0.45.0)
as the toolkit were expected to run with golang 1.23, some of the component and dependencies does not met the 1.24 vet requirement hence skip this. these are currently reported error pkgworker/pkgworker.go:427:22: non-constant format string in call to fmt.Errorf imagegen/installutils/installutils.go:2079:21: non-constant format string in call to (*github.com/sirupsen/logrus.Logger).Warnf imagegen/installutils/installutils.go:3142:20: non-constant format string in call to (*github.com/sirupsen/logrus.Logger).Warnf graphpkgfetcher/graphpkgfetcher.go:315:79: non-constant format string in call to (*github.com/sirupsen/logrus.Logger).Debugf scheduler/schedulerutils/preparerequest.go:96:21: non-constant format string in call to (*github.com/sirupsen/logrus.Logger).Warnf scheduler/schedulerutils/preparerequest.go:189:21: non-constant format string in call to (*github.com/sirupsen/logrus.Logger).Warnf internal/packagerepo/repocloner/rpmrepocloner/rpmrepocloner.go:920:21: non-constant format string in call to fmt.Errorf internal/packagerepo/repomanager/rpmrepomanager/rpmrepomanager.go:114:78: non-constant format string in call to fmt.Errorf Signed-off-by: Lee Chee Yang <chee.yang.lee@intel.com>
Signed-off-by: Lee Chee Yang <chee.yang.lee@intel.com>
Signed-off-by: Lee Chee Yang <chee.yang.lee@intel.com>
andy-vm
requested changes
Jan 29, 2026
Contributor
andy-vm
left a comment
andy-vm
left a comment
There was a problem hiding this comment.
need to fix the CI errors
Signed-off-by: Lee Chee Yang <chee.yang.lee@intel.com>
cheeyanglee
force-pushed
the
3.0-dev-toolkit-go1.24.12
branch
2 times, most recently
from
d1b8690 to
b587927
Compare
Signed-off-by: Lee Chee Yang <chee.yang.lee@intel.com>
cheeyanglee
force-pushed
the
3.0-dev-toolkit-go1.24.12
branch
from
b587927 to
763201a
Compare
andy-vm
approved these changes
Jan 29, 2026
cheeyanglee
merged commit e730576
into
open-edge-platform:3.0-dev
17 of 21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR
Description
The goal for this PR is to fix for CVE listed under #593 .
As ubuntu 22.04 does not officially support for golang 1.24 or newer version through apt package, we will take the golang binaries from upstream go.dev site .
disable vet as this would failed the test for known minor issue "non-constant format string in call"
This required changes in build host too.
Any Newly Introduced Dependencies
How Has This Been Tested?