Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the React Compiler to the project by adding the necessary babel plugin configuration and updating dependencies. The React Compiler helps optimize React components by automatically handling memoization and reducing unnecessary re-renders.
- Configures React Compiler through babel plugin in the build system
- Updates React hooks ESLint plugin to support React Compiler
- Refactors
ImgBoxescomponent from function call pattern to proper JSX component usage
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
web_ui/rsbuild.config.ts |
Adds babel plugin configuration to enable React Compiler |
web_ui/package.json |
Adds React Compiler dependencies and updates ESLint plugin version |
web_ui/eslint.config.js |
Adds commented ESLint rule for React refs during render |
web_ui/src/pages/create-project/components/select-project-template/utils.tsx |
Converts ImgBoxes from function call to proper React component with props |
Files not reviewed (1)
- web_ui/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR enables react compiler. As you can see in the lint CI job, we have bunch of errors there. Lot's of them are because compiler cannot replace 1:1 our memo
(e.g.
incorrect (current state):
correct (without eslint warning):
)
or we use
refduring the render (Cannot access refs during render). I think the memo errors we should fix but I'm not sure if we should fixrefissues. Please check the lint logs. I'm waiting for your feedback.✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: