Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in user filtering logic where filtering by resource type alone was incorrectly requiring a resource ID. The fix allows filtering users based solely on resource type without needing a specific workspace ID.
- Changed the filtering condition to require both resource type AND resource ID instead of resource type OR resource ID
- Added debug logging to help track role filtering behavior
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Currently - filtering a list of users based on resourceType only includes also id of a workspaces that belongs to a caller of this endpoint. Within this PR I removed this additional filtering - resolving the issue found during diagnosis of the #1274.
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Check if on environments with support for multi workspaces a list of users for "All workspaces" contains the same users as when you choose any certain workspace.
✅ Checklist
Before submitting the PR, ensure the following: