-
Notifications
You must be signed in to change notification settings - Fork 21
Template componnets charts #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
edc7057
to
d9ce8d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Great work, Maciej! just two minor comments
2698ffa
to
f160175
Compare
e8651f0
to
532e404
Compare
0f0f2aa
to
ea652dc
Compare
ea652dc
to
47af510
Compare
47af510
to
74deb22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Maciej. Looks good to me.
@@ -148,7 +148,7 @@ make tests | |||
- `build`: Create binaries | |||
- `publish`: Publish artifacts to registries | |||
- `build-image`: Build a container image | |||
- `push-image`: Publish a container image | |||
- `publish-image`: Publish a container image | |||
- `lint-chart`: Lint a helm chart | |||
- `publish-chart`: Publish a helm chart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `publish-chart`: Publish a helm chart | |
- `build-chart`: Build a helm chart | |
- `publish-chart`: Publish a helm chart |
74deb22
to
edccb1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Maciej!
📝 Description
Provide a clear summary of the changes and the context behind them. Describe what was changed, why it was needed, and how the changes address the issue or add value.
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: