Skip to content

Template componnets charts #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mramotowski
Copy link
Contributor

📝 Description

Provide a clear summary of the changes and the context behind them. Describe what was changed, why it was needed, and how the changes address the issue or add value.

✨ Type of Change

Select the type of change your PR introduces:

  • 🐞 Bug fix – Non-breaking change which fixes an issue
  • 🚀 New feature – Non-breaking change which adds functionality
  • 🔨 Refactor – Non-breaking change which refactors the code base
  • 💥 Breaking change – Changes that break existing functionality
  • 📚 Documentation update
  • 🔒 Security update
  • 🧪 Tests

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

  • ✅ Tested manually
  • 🤖 Run automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

  • 🔍 PR title is clear and descriptive
  • 📝 For internal contributors: If applicable, include the JIRA ticket number (e.g., ITEP-123456) in the PR title. Do not include full URLs
  • 💬 I have commented my code, especially in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ✅ I have added tests that prove my fix is effective or my feature works

Copy link
Contributor

@mpryahin mpryahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Great work, Maciej! just two minor comments

@mramotowski mramotowski force-pushed the update_chart_versioning branch 2 times, most recently from 2698ffa to f160175 Compare May 12, 2025 12:29
@mramotowski mramotowski requested a review from mpryahin May 13, 2025 07:52
@mramotowski mramotowski force-pushed the update_chart_versioning branch 3 times, most recently from e8651f0 to 532e404 Compare May 13, 2025 10:58
@mramotowski mramotowski force-pushed the update_chart_versioning branch 3 times, most recently from 0f0f2aa to ea652dc Compare May 13, 2025 13:11
@mramotowski mramotowski requested a review from mpryahin May 14, 2025 05:39
@mramotowski mramotowski force-pushed the update_chart_versioning branch from ea652dc to 47af510 Compare May 19, 2025 05:35
@mramotowski mramotowski force-pushed the update_chart_versioning branch from 47af510 to 74deb22 Compare May 19, 2025 09:18
mpryahin
mpryahin previously approved these changes May 19, 2025
Copy link
Contributor

@mpryahin mpryahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Maciej. Looks good to me.

@@ -148,7 +148,7 @@ make tests
- `build`: Create binaries
- `publish`: Publish artifacts to registries
- `build-image`: Build a container image
- `push-image`: Publish a container image
- `publish-image`: Publish a container image
- `lint-chart`: Lint a helm chart
- `publish-chart`: Publish a helm chart
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `publish-chart`: Publish a helm chart
- `build-chart`: Build a helm chart
- `publish-chart`: Publish a helm chart

Copy link
Contributor

@mpryahin mpryahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Maciej!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IAI Interactive AI backend Platform UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants