ITEP-32484 - Implement GET project_configuration endpoint #220
Conversation
| # The project configuration is a Pydantic model, so we can simply convert it to a dict | ||
| return project_config.model_dump() |
There was a problem hiding this comment.
I'm afraid you can't obtain the right response structure by only calling model_dump. According to the design, each parameter should have a "key", "name", "description", "type", "value", "min_value", "max_value", "default_value", etc... You can extract this information from the configuration Fields but you have to write some custom logic.
There was a problem hiding this comment.
You're right, added configuration rest view class
Edit: added configurable_parameters_to_rest which construct the REST view from any pydantic model.
interactive_ai/services/director/app/communication/endpoints/project_configuration_endpoints.py
Outdated
Show resolved
Hide resolved
| """ | ||
| project_config = ProjectConfigurationRepo(project_identifier).get_project_configuration() | ||
| if isinstance(project_config, NullProjectConfiguration): | ||
| raise ProjectNotFoundException(project_identifier.project_id) |
There was a problem hiding this comment.
Perhaps it is cleaner to create a new ProjectConfigurationNotFoundException or to use a custom message indicating that the configuration could not be found.
📝 Description
Add
GET project_configurationendpoint✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: