:chore: ITEP-66905 - UI components cleanup [PART 2] #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpggvilaca
requested review from
pplaskie,
ActiveChooN,
romanowska and
dwesolow
as code owners
There was a problem hiding this comment.
Pull Request Overview
A refactor PR targeting UI component cleanup and import consolidations in the annotator and analytics sections.
- Consolidated and unified import statements across multiple components
- Adjusted export settings for an interface and a component
- Removed dead code and updated package imports to use meta packages
Reviewed Changes
Copilot reviewed 78 out of 80 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| web_ui/src/pages/annotator/tools/ssim-tool/secondary-toolbar.component.tsx | Combined import statements from separate packages |
| web_ui/src/pages/annotator/tools/rotated-bounding-box-tool/secondary-toolbar.component.tsx | Combined import statements from separate packages |
| web_ui/src/pages/annotator/tools/polygon-tool/secondary-toolbar.component.tsx | Combined import statements from separate packages |
| web_ui/src/pages/annotator/tools/polygon-tool/polygon-tool.interface.ts | Removed export from an interface |
| web_ui/src/pages/annotator/tools/keypoint-tool/secondary-toolbar.component.tsx | Combined import statements from separate packages |
| web_ui/src/pages/annotator/tools/grabcut-tool/secondary-toolbar.component.tsx | Combined import statements from separate packages |
| web_ui/src/pages/annotator/tools/explanation-tool/select-model.component.tsx | Changed export declaration to a local const |
| web_ui/src/pages/annotator/tools/circle-tool/secondary-toolbar.component.tsx | Combined import statements from separate packages |
| web_ui/src/pages/annotator/tools/bounding-box/secondary-toolbar.component.tsx | Combined import statements from separate packages |
| web_ui/src/pages/annotator/components/video-player/propagate-annotations/propagate-annotations-dialog.component.tsx | Updated import for Heading to use meta package |
| web_ui/src/pages/annotator/components/sidebar/annotations/annotations-header.component.tsx | Combined import statements from separate packages |
| web_ui/src/pages/annotator/components/secondary-toolbar/replace-or-merge-user-annotations-dialog.component.tsx | Updated import for Heading to use meta package |
| web_ui/src/pages/annotator/components/primary-toolbar/primary-toolbar.component.tsx | Consolidated Provider and View imports from meta package |
| web_ui/src/pages/annotator/components/labels/selectable-label-tag/selectable-label-tag.component.tsx | Updated import for View to use meta package |
| web_ui/src/pages/annotator/components/labels/label-search/label-result-panel.component.tsx | Consolidated import statements from separate packages |
| web_ui/src/pages/annotator/components/footer/annotator-footer.component.tsx | Consolidated import statements from separate packages |
| web_ui/src/pages/annotator/annotation/annotation-filter/corner-indicator.component.tsx | Updated import for View to use meta package |
| web_ui/src/pages/analytics/analytics-dashboard-card.component.tsx | Updated import for Heading to use meta package and consolidated imports |
Files not reviewed (2)
- web_ui/package-lock.json: Language not supported
- web_ui/package.json: Language not supported
Comments suppressed due to low confidence (2)
web_ui/src/pages/annotator/tools/polygon-tool/polygon-tool.interface.ts:11
- Removing the 'export' keyword restricts the interface's visibility; please verify that this change is intentional and won't affect external usage if the interface was meant to be shared.
-export interface IntelligentScissorsInstance {
web_ui/src/pages/annotator/tools/explanation-tool/select-model.component.tsx:28
- Changing the component from an exported function to a locally defined constant may impact its external availability; confirm that this change is deliberate.
-export const SelectInferenceModelPicker = (props: Omit<ComponentProps<typeof Picker>, 'children'>) => {
jpggvilaca
commented
May 15, 2025
dwesolow
reviewed
May 16, 2025
| @@ -5,8 +5,7 @@ import { Dispatch, FC, ReactNode, SVGProps } from 'react'; | |||
|
|
|||
| import { Divider, Flex, IllustratedMessage, View } from '@adobe/react-spectrum'; | |||
| import { useMediaQuery } from '@react-spectrum/utils'; | |||
| import { DimensionValue } from '@react-types/shared/src/dna'; | |||
| import { Responsive } from '@react-types/shared/src/style'; | |||
| import { DimensionValue, Responsive } from '@react-types/shared'; | |||
There was a problem hiding this comment.
Based on loading-overlay.component.tsx I can see that DimensionValue is also available in the @adobe/react-spectrum. Could you update this as well?
dwesolow
force-pushed
the
jvilaca/ITEP-66905-ui-components-cleanup-2
branch
from
49bda51 to
e48f1ef
Compare
| @@ -67,7 +67,6 @@ | |||
| "react-webcam": "^7.2.0", | |||
| "react-zoom-pan-pinch": "^3.7.0", | |||
| "recharts": "^2.15.1", | |||
| "screenfull": "^6.0.2", | |||
There was a problem hiding this comment.
Good Q, i have no idea.
There was a problem hiding this comment.
It was used fot learning videos that got removed some time ago.
| checkMarkColor?: ColorValue | string; | ||
| } | ||
|
|
||
| export const CircularProgress = ({ |
There was a problem hiding this comment.
Doesn't it need tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
screenfullpackage✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: