ITEP-66910 - Fix adding a label on a subgroup #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpggvilaca
requested review from
MarkRedeman,
camiloHimura,
pplaskie,
ActiveChooN,
romanowska and
dwesolow
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the payload for adding a label under a subgroup by using the element’s id instead of its name.
- Updated the label payload to reference
parentElement.idfor subgroup relationships. - Adjusted the unit test to assert the new
parentLabelIdvalue.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| web_ui/src/core/projects/hooks/utils.ts | Switched parentLabelId from parentElement.name to parentElement.id. |
| web_ui/src/core/projects/hooks/utils.test.ts | Updated the expected parentLabelId in the test to match the new UUID. |
|
Could you add a unit test for this? |
it exists already. i updated it. it failed when i made the change |
MarkRedeman
reviewed
May 15, 2025
| return getNewLabelPayloadNew({ ...label, parentLabelId: parentElement.name }, shouldRevisit); | ||
| return getNewLabelPayloadNew({ ...label, parentLabelId: parentElement.id }, shouldRevisit); |
There was a problem hiding this comment.
Does this also work when creating a new group hiearchy? I.e. when the parentElement is also a new label (so therefore not having an id)
There was a problem hiding this comment.
I also thought about that case - the problem is that during creation we do not have id, only the name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: