:chores: Moved dataset import/export to its own feature folder by jpggvilaca · Pull Request #249 · open-edge-platform/geti

jpggvilaca · 2025-05-20T11:23:40Z

📝 Description

Before:
pages/landing-page/landing-page-workspace/components/dataset-import-to-new-project
shared/components/dataset-import-deletion-dialog
project-details/components/project-dataset/dataset-imports
...other scattered folders

After:

✨ Type of Change

Select the type of change your PR introduces:

🐞 Bug fix – Non-breaking change which fixes an issue
🚀 New feature – Non-breaking change which adds functionality
🔨 Refactor – Non-breaking change which refactors the code base
💥 Breaking change – Changes that break existing functionality
📚 Documentation update
🔒 Security update
🧪 Tests

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

✅ Tested manually
🤖 Run automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

🔍 PR title is clear and descriptive
📝 For internal contributors: If applicable, include the JIRA ticket number (e.g., ITEP-123456) in the PR title. Do not include full URLs
💬 I have commented my code, especially in hard-to-understand areas
📄 I have made corresponding changes to the documentation
✅ I have added tests that prove my fix is effective or my feature works

Copilot

Pull Request Overview

This PR refactors the codebase by consolidating all dataset export functionality into a new features/dataset-export folder, updating import paths and module references accordingly. It centralizes export-related components, hooks, and utilities under one feature, and renames CSS modules to dataset-export.module.scss.

Updated import paths in tests and components to reflect new feature directory structure
Renamed styling modules from project-dataset.module.scss to dataset-export.module.scss and removed an unsafe className on a divider
Moved IntervalJobHandlers type import from core datasets to feature dataset-import, creating a cross-feature dependency

Reviewed Changes

Copilot reviewed 75 out of 76 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
web_ui/src/features/dataset-export/utils/utils.test.ts	Adjusted import path for `ExportFormats`
web_ui/src/features/dataset-export/hooks/use-export-dataset.hook.ts	Updated `IntervalJobHandlers` import location
web_ui/src/features/dataset-export/components/export-import-dataset-dialog-provider.component.tsx	Adjusted provider import path
web_ui/src/features/dataset-export/components/export-import-dataset-buttons.test.tsx	Updated test imports and mocks paths
web_ui/src/features/dataset-export/components/export-import-dataset-buttons.component.tsx	Reordered imports and updated paths
web_ui/src/features/dataset-export/components/export-dataset-status-job.test.tsx	Updated import paths in tests
web_ui/src/features/dataset-export/components/export-dataset-status-job.component.tsx	Updated imports and CSS module reference
web_ui/src/features/dataset-export/components/export-dataset-notification.test.tsx	Adjusted import paths in tests
web_ui/src/features/dataset-export/components/export-dataset-notification.component.tsx	Updated import paths
web_ui/src/features/dataset-export/components/export-dataset-message.test.tsx	Fixed relative import for utils
web_ui/src/features/dataset-export/components/export-dataset-message.component.tsx	Updated imports and CSS module reference
web_ui/src/features/dataset-export/components/export-dataset-download.test.tsx	Adjusted import paths and mocks
web_ui/src/features/dataset-export/components/export-dataset-download.component.tsx	Updated imports and CSS module reference
web_ui/src/features/dataset-export/components/export-dataset-dialog.test.tsx	Updated test imports and mocks
web_ui/src/features/dataset-export/components/export-dataset-dialog.component.tsx	Adjusted imports, removed unsafe className on Divider
web_ui/src/features/dataset-export/components/dataset-statistics.test.tsx	Updated import paths in tests
web_ui/src/core/datasets/hooks/utils.ts	Changed `IntervalJobHandlers` import to feature

Files not reviewed (1)

web_ui/src/features/dataset-export/components/dataset-export.module.scss: Language not supported

web_ui/src/features/dataset-export/components/export-dataset-dialog.component.tsx

Copilot · 2025-05-20T11:56:03Z

web_ui/src/core/datasets/hooks/utils.ts

 import { StatusCodes } from 'http-status-codes';
 import { isFunction } from 'lodash-es';

+import { IntervalJobHandlers } from '../../../features/dataset-import/types/dataset-import.interface';


[nitpick] Core utilities should not depend on feature-level types to avoid cyclic or inverted dependencies. Consider moving IntervalJobHandlers to a shared core or common package.

+1. We don't want to import anything from features/pages to core.

Agree! Moved to shared

Copilot · 2025-05-20T11:56:03Z

web_ui/src/features/dataset-export/hooks/use-export-dataset.hook.ts

 import { isStateDone, isStateError } from '../../../core/projects/hooks/utils';
 import QUERY_KEYS from '../../../core/requests/query-keys';
 import { useApplicationServices } from '../../../core/services/application-services-provider.component';
+import { IntervalJobHandlers } from '../../../features/dataset-import/types/dataset-import.interface';


[nitpick] Importing IntervalJobHandlers from the dataset-import feature couples export logic to import-specific types. It may be cleaner to define a shared type in core or a common folder.

dwesolow · 2025-05-21T07:04:17Z

OPENS:

Should we move services?

Should we move providers?

I don't think so, we want to have core that contains services and is reusable (e.g. for testing contracts etc).
IMO it's good idea to move related providers to their feature.

dwesolow · 2025-05-26T08:10:41Z

...ts/dataset-import-to-existing-project/dataset-import-to-existing-project-map-labels.test.tsx

-                projectLabels={mockProjectLabels}
-                activeDatasetImport={{ ...mockDatasetImportItem, labels: ['cat'] }}
-            />
+            <Provider theme={defaultTheme}>


why do we need this provider?

Good Q, i also dont know why ONLY this test started failing, but i didnt waste too much time going deep into this for now

dwesolow · 2025-05-26T08:18:07Z

web_ui/src/shared/utils.ts

+export const getIntervalJobHandlers =
+    <T extends JobGeneralProps>({
+        onSuccess,
+        onSettled,
+        onError,
+        onCancel,
+        onCancelOrFailed,
+    }: IntervalJobHandlers<T>) =>
+    (jobResponse: T) => {
+        if (isJobDone(jobResponse)) {
+            onSuccess(jobResponse);
+        }
+
+        if (isJobFailed(jobResponse)) {
+            onError({
+                message: getFailedJobMessage(jobResponse),
+                response: { status: StatusCodes.NOT_IMPLEMENTED },
+            } as AxiosError);
+
+            isFunction(onCancelOrFailed) && onCancelOrFailed();
+        }
+
+        if (isJobCancel(jobResponse)) {
+            isFunction(onCancel) && onCancel();
+
+            isFunction(onCancelOrFailed) && onCancelOrFailed();
+        }
+
+        if (isJobSettled(jobResponse)) {
+            isFunction(onSettled) && onSettled(jobResponse);
+        }
+    };


https://jira.devtools.intel.com/browse/ITEP-31796

out of scope of this PR but yes, good reminder : )

jpggvilaca requested review from ActiveChooN, MarkRedeman, camiloHimura and pplaskie as code owners May 20, 2025 11:23

jpggvilaca added the UI label May 20, 2025

jpggvilaca requested review from dwesolow and romanowska as code owners May 20, 2025 11:23

jpggvilaca added the ready for review label May 20, 2025

jpggvilaca force-pushed the jvilaca/chores-dataset-import-feature branch from 192a253 to 94db4d3 Compare May 20, 2025 11:24

jpggvilaca added the do not merge label May 20, 2025

jpggvilaca requested a review from Copilot May 20, 2025 11:53

Copilot AI reviewed May 20, 2025

View reviewed changes

jpggvilaca force-pushed the jvilaca/chores-dataset-import-feature branch from edb0c54 to 60ceaeb Compare May 23, 2025 14:01

jpggvilaca removed the do not merge label May 23, 2025

dwesolow reviewed May 26, 2025

View reviewed changes

jpggvilaca mentioned this pull request May 26, 2025

ITEP-66302 Move src/core/services and src/core/requests to @geti/core @geti/core [PART 4] #289

Merged

14 tasks

jpggvilaca added 6 commits June 4, 2025 13:00

Moved dataset ie to features folder

e66bf5d

Fix tests

32d47fb

Fix lint

294712c

Remove duplicated file

580912e

Move providers

e4e120d

Move job utils to shared folder

0907ccb

jpggvilaca force-pushed the jvilaca/chores-dataset-import-feature branch from f2e9653 to 0907ccb Compare June 4, 2025 11:02

jpggvilaca added 3 commits June 4, 2025 13:13

Fix rebase conflicts

17bdbeb

Fix 1 more conflict

012112b

Fix cyclic dependency

047e6b0

jpggvilaca closed this Jul 17, 2025

jpggvilaca deleted the jvilaca/chores-dataset-import-feature branch September 9, 2025 10:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

:chores: Moved dataset import/export to its own feature folder#249

:chores: Moved dataset import/export to its own feature folder#249
jpggvilaca wants to merge 9 commits intomainfrom
jvilaca/chores-dataset-import-feature

jpggvilaca commented May 20, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI May 20, 2025

Uh oh!

dwesolow May 21, 2025

Uh oh!

jpggvilaca May 26, 2025

Uh oh!

Copilot AI May 20, 2025

Uh oh!

dwesolow commented May 21, 2025 •

edited

Loading

Uh oh!

dwesolow May 26, 2025

Uh oh!

jpggvilaca May 26, 2025

Uh oh!

dwesolow May 26, 2025

Uh oh!

jpggvilaca May 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

jpggvilaca commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

✨ Type of Change

🧪 Testing Scenarios

✅ Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI May 20, 2025

Choose a reason for hiding this comment

Uh oh!

dwesolow May 21, 2025

Choose a reason for hiding this comment

Uh oh!

jpggvilaca May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 20, 2025

Choose a reason for hiding this comment

Uh oh!

dwesolow commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dwesolow May 26, 2025

Choose a reason for hiding this comment

Uh oh!

jpggvilaca May 26, 2025

Choose a reason for hiding this comment

Uh oh!

dwesolow May 26, 2025

Choose a reason for hiding this comment

Uh oh!

jpggvilaca May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jpggvilaca commented May 20, 2025 •

edited

Loading

dwesolow commented May 21, 2025 •

edited

Loading