ITEP-31006 Anomaly Reduction clean up #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o aurelien/anomaly-reduction-cleanup # Conflicts: # interactive_ai/data_migration/migration/changelog/30.json
…o aurelien/anomaly-reduction-cleanup # Conflicts: # interactive_ai/services/director/app/communication/controllers/model_test_controller.py # interactive_ai/services/director/app/communication/views/annotation_rest_views.py # interactive_ai/services/director/app/communication/views/model_template_rest_views.py # interactive_ai/services/director/app/communication/views/performance_rest_views.py # interactive_ai/services/director/app/features/feature_flag_provider.py # interactive_ai/services/director/tests/unit/communication/rest_controllers/test_model_test_controller.py # interactive_ai/services/director/tests/unit/communication/rest_views/test_annotation_rest_views.py # interactive_ai/services/director/tests/unit/communication/rest_views/test_model_template_rest_views.py # interactive_ai/services/director/tests/unit/communication/rest_views/test_performance_rest_views.py # interactive_ai/services/director/tests/unit/communication/test_rest_datamodels.py
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up obsolete anomaly reduction logic by removing the FEATURE_FLAG_ANOMALY_REDUCTION flag from various parts of the code and unifying anomaly task types into a single ANOMALY enum value. In addition, it introduces a new data migration script to update legacy anomaly representations and bumps the project data version.
- Removed obsolete feature flag checks and related test fixtures.
- Updated the anomaly task type to a unified ANOMALY value in enums and test expectations.
- Added a migration script (with corresponding tests and metadata) to reduce anomaly tasks.
Reviewed Changes
Copilot reviewed 48 out of 48 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| interactive_ai/services/director/tests/unit/... | Removed obsolete feature flag imports and calls in tests. |
| interactive_ai/services/dataset_ie/app/... | Updated feature flag usage and project type mapping. |
| interactive_ai/libs/iai_core_py/iai_core/utils/project_builder.py | Removed anomaly-specific renaming logic to align with streamlined task type representation. |
| interactive_ai/data_migration/migration/scripts/reduce_anomaly_tasks.py | New migration script for anomaly reduction with recursive field updates. |
| interactive_ai/libs/iai_core_py/iai_core/entities/... | Added the unified ANOMALY task type and updated related constants. |
Contributor
JortBergfeld
left a comment
JortBergfeld
left a comment
There was a problem hiding this comment.
LGTM, I am just wondering why a new domain had to be introduced in this PR, and why the old ones are not removed.
leoll2
reviewed
Jun 20, 2025
leoll2
previously approved these changes
Jun 20, 2025
…o aurelien/anomaly-reduction-cleanup # Conflicts: # interactive_ai/libs/iai_core_py/iai_core/versioning/data_version.txt
leoll2
previously approved these changes
Jul 14, 2025
leoll2
approved these changes
Jul 15, 2025
piotrgrubicki
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Adds a data migrations script to clean up the database of local anomaly references.
The following collections are affected
["annotation_scene", "annotation_scene_state", "project", "label", "label_schema", "model", "model_storage", "task_node"]Removes the
FEATURE_FLAG_ANOMALY_REDUCTIONand cleans up remaining code related to local anomaly tasks.The dataset IE still supports
GetiProjectType.ANOMALY_CLASSIFICATIONGetiProjectType.ANOMALY_DETECTIONGetiProjectType.ANOMALY_SEGMENTATIONso that old exported datasets can be imported to the new
GetProjectType.ANOMALY✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: