Conversation
Signed-off-by: Yu, Fei <fei.yu@intel.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the execution path parameter across shell command invocations by replacing empty strings ("") with the explicit shell.HostPath constant. The constant itself is updated from an empty string to "/", clearly indicating host system execution context.
Key Changes:
- Updated
shell.HostPathconstant from""to"/" - Replaced all empty string parameters in
shell.ExecCmd*andshell.IsCommandExistcalls withshell.HostPathconstant - Ensures consistent and explicit specification of host execution context throughout the codebase
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/utils/shell/shell.go | Changed HostPath constant from empty string to "/" |
| internal/utils/system/system.go | Updated ExecCmd calls to use shell.HostPath for host OS detection commands |
| internal/utils/mount/mount.go | Standardized mount operations to explicitly use shell.HostPath |
| internal/utils/file/file.go | Updated file operations to use shell.HostPath constant |
| internal/utils/compression/compression.go | Applied shell.HostPath to compression/decompression commands |
| internal/provider/emt/emt.go | Updated dependency installation to use shell.HostPath |
| internal/provider/elxr/elxr.go | Updated dependency installation to use shell.HostPath |
| internal/provider/azl/azl.go | Updated dependency installation to use shell.HostPath |
| internal/image/* | Applied shell.HostPath across all image building modules |
| internal/chroot/* | Standardized chroot-related operations to use shell.HostPath |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yockgen
approved these changes
Oct 27, 2025
yockgen
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR
Description
Any Newly Introduced Dependencies
How Has This Been Tested?