Skip to content

Clear specify host execution path with shell cmd#274

Merged
yockgen merged 2 commits intomainfrom
dev_feiyu
Oct 28, 2025
Merged

Clear specify host execution path with shell cmd#274
yockgen merged 2 commits intomainfrom
dev_feiyu

Conversation

@feiyu11859661
Copy link
Copy Markdown
Contributor

Merge Checklist

All boxes should be checked before merging the PR

  • The changes in the PR have been built and tested
  • Ready to merge

Description

Any Newly Introduced Dependencies

How Has This Been Tested?

Signed-off-by: Yu, Fei <fei.yu@intel.com>
Copilot AI review requested due to automatic review settings October 27, 2025 05:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the execution path parameter across shell command invocations by replacing empty strings ("") with the explicit shell.HostPath constant. The constant itself is updated from an empty string to "/", clearly indicating host system execution context.

Key Changes:

  • Updated shell.HostPath constant from "" to "/"
  • Replaced all empty string parameters in shell.ExecCmd* and shell.IsCommandExist calls with shell.HostPath constant
  • Ensures consistent and explicit specification of host execution context throughout the codebase

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
internal/utils/shell/shell.go Changed HostPath constant from empty string to "/"
internal/utils/system/system.go Updated ExecCmd calls to use shell.HostPath for host OS detection commands
internal/utils/mount/mount.go Standardized mount operations to explicitly use shell.HostPath
internal/utils/file/file.go Updated file operations to use shell.HostPath constant
internal/utils/compression/compression.go Applied shell.HostPath to compression/decompression commands
internal/provider/emt/emt.go Updated dependency installation to use shell.HostPath
internal/provider/elxr/elxr.go Updated dependency installation to use shell.HostPath
internal/provider/azl/azl.go Updated dependency installation to use shell.HostPath
internal/image/* Applied shell.HostPath across all image building modules
internal/chroot/* Standardized chroot-related operations to use shell.HostPath

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/image/imageos/imageos.go
Comment thread internal/image/imageos/imageos.go
@feiyu11859661 feiyu11859661 requested a review from a team October 27, 2025 06:54
@yockgen yockgen merged commit 2f4574f into main Oct 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants