Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new internal shell utility package to resolve command binaries by full path, manage environment variables, and provide flexible command execution (with sudo, chroot, streaming, and input support).
- Defines a
commandMapfor absolute binary lookups and implementsverifyCmdWithFullPath - Provides helpers for fetching OS environments and proxy settings
- Adds
GetFullCmdStr,ExecCmd,ExecCmdWithStream, andExecCmdWithInputfunctions
Comments suppressed due to low confidence (2)
internal/utils/general/shell/shell.go:122
- Function name
IsCommandExistsuggests a boolean return, but it returns a string path. Consider renaming toGetCommandPathor changing the signature to return abool.
func IsCommandExist(cmd string, chrootPath string) string {
internal/utils/general/shell/shell.go:1
- [nitpick] The new shell package lacks unit tests. Adding tests for key functions like
GetFullCmdStr,ExecCmdWithStream, andverifyCmdWithFullPathwould improve reliability.
package shell
magerstam
reviewed
Jun 4, 2025
magerstam
reviewed
Jun 4, 2025
Contributor
magerstam
left a comment
There was a problem hiding this comment.
Overall looks nice and clean, just a suggestion on the hard coded map for commands.
magerstam
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR
Description
Any Newly Introduced Dependencies
How Has This Been Tested?