Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables PTL BKC (Best Known Configuration) image build support for Ubuntu by implementing comprehensive package repository management, priority-based package resolution, and shell command parsing improvements.
Changes:
- Added APT repository priority system with preference file generation
- Enhanced shell command parsing to handle nested quotes and special characters
- Implemented GPG key management and trusted repository support
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/utils/shell/shell_yaml_config_test.go | Tests for echo commands with nested quotes and chroot verification |
| internal/utils/shell/shell.go | Enhanced quote parsing, added command mappings, and improved separator detection |
| internal/provider/ubuntu/ubuntu.go | Repository priority support and user repository integration |
| internal/provider/elxr/elxr.go | APT sources generation from repositories |
| internal/ospackage/debutils/verify_test.go | Test for trusted repository verification bypass |
| internal/ospackage/debutils/resolver.go | APT priority-based package resolution and conflict handling |
| internal/ospackage/debutils/download.go | Repository priority field addition |
| internal/image/imageos/imageos.go | AppArmor wrapper for chroot environment |
| internal/config/validate/validate_test.go | Validation tests for trusted repositories |
| internal/config/schema/os-image-template.schema.json | Schema updates for repository priorities and trusted repos |
| internal/config/global.go | Default temp directory change to ./tmp |
| internal/config/config.go | Priority field added to PackageRepository |
| internal/config/apt_sources_test.go | Comprehensive tests for APT sources generation |
| internal/config/apt_sources_integration_test.go | Integration tests for repository configuration |
| internal/config/apt_sources.go | APT sources and preferences file generation logic |
| image-templates/ubuntu24-x86_64-minimal-ptl.yml | PTL BKC image template with repository configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
samueltaripin
force-pushed
the
multirepo-priority
branch
2 times, most recently
from
e5324b9 to
d6aefd1
Compare
yockgen
approved these changes
Jan 27, 2026
samueltaripin
force-pushed
the
multirepo-priority
branch
from
b823442 to
48ba96c
Compare
samueltaripin
force-pushed
the
multirepo-priority
branch
from
9d46289 to
4f84ab9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR
Description
Any Newly Introduced Dependencies
How Has This Been Tested?