Skip to content

fixed the broken unit tests#40

Closed
arodage wants to merge 1 commit intomainfrom
unit-test-failure-fix
Closed

fixed the broken unit tests#40
arodage wants to merge 1 commit intomainfrom
unit-test-failure-fix

Conversation

@arodage
Copy link
Copy Markdown
Contributor

@arodage arodage commented Jun 9, 2025

Merge Checklist

All boxes should be checked before merging the PR

  • The changes in the PR have been built and tested
  • [] Ready to merge

Description

  • Removed hardcoded commandMap with absolute paths
  • Implemented PATH-based command resolution using shell's built-in command lookup
  • Added dynamic shell detection (bash → /bin/sh fallback)
  • Updated test to match new behavior (expects echo hello instead of /usr/bin/echo hello)

Any Newly Introduced Dependencies

How Has This Been Tested?

@feiyu11859661 feiyu11859661 requested a review from yockgen June 10, 2025 02:37
@feiyu11859661
Copy link
Copy Markdown
Contributor

Why remove the cmd map?

@arodage
Copy link
Copy Markdown
Contributor Author

arodage commented Jun 17, 2025

@feiyu11859661 Closing this PR. I will let you take care of it. We might need some mock implementation if we really need a code coverage.

@arodage arodage closed this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants