Skip to content

Ubuntu PTL with DLS and Fixes for apt update not working#418

Merged
srmungar merged 5 commits intomainfrom
ptl_dls
Feb 18, 2026
Merged

Ubuntu PTL with DLS and Fixes for apt update not working#418
srmungar merged 5 commits intomainfrom
ptl_dls

Conversation

@samueltaripin
Copy link
Copy Markdown
Contributor

Merge Checklist

All boxes should be checked before merging the PR

  • [/] The changes in the PR have been built and tested
  • [/] Ready to merge

Description

  1. Apt update fixed
  2. Ubuntu PTL with DLS

Any Newly Introduced Dependencies

How Has This Been Tested?

@samueltaripin samueltaripin requested a review from a team as a code owner February 16, 2026 09:57
Copilot AI review requested due to automatic review settings February 16, 2026 09:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes apt update issues by modifying GPG key handling and apt sources configuration, and adds a new Ubuntu 24.04 PTL (Panther Lake) image template with DLS (DL Streamer) support. The changes move away from using signed-by directives in apt sources to a simpler format that relies on GPG keys placed in the global trusted keyring directory.

Changes:

  • Modified apt sources generation to use simple format without signed-by directives
  • Changed GPG key storage location from /usr/share/keyrings/ to /etc/apt/trusted.gpg.d/
  • Added automatic GPG key dearmorming (ASCII to binary conversion)
  • Added new Ubuntu 24.04 PTL image template with DLS packages

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 12 comments.

File Description
internal/config/apt_sources.go Removed signed-by directives from apt sources generation, changed GPG key paths to /etc/apt/trusted.gpg.d/, added dearmorGPGKey function, consolidated GPG key file creation logic, and added 0644 permissions to GPG key files
config/osv/ubuntu/ubuntu24/imageconfigs/additionalfiles/ubuntu-noble.list Updated to simple deb line format without signed-by directives
image-templates/ubuntu24-x86_64-minimal-ptl-dls.yml New image template for Ubuntu 24.04 PTL with DLS support including Docker, DL Streamer, and PTL-specific packages and configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/config/apt_sources.go Outdated
Comment thread internal/config/apt_sources.go
Comment thread internal/config/apt_sources.go
Comment thread internal/config/apt_sources.go
Comment thread image-templates/ubuntu24-x86_64-minimal-ptl-dls.yml
Comment thread image-templates/ubuntu24-x86_64-minimal-ptl-dls.yml
Comment thread internal/config/apt_sources.go
Comment thread internal/config/apt_sources.go
Comment thread image-templates/ubuntu24-x86_64-minimal-ptl-dls.yml Outdated
Comment thread internal/config/apt_sources.go
samueltaripin and others added 3 commits February 16, 2026 18:40
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@srmungar srmungar merged commit 51a8038 into main Feb 18, 2026
37 checks passed
@samueltaripin samueltaripin deleted the ptl_dls branch March 2, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants