Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes apt update issues by modifying GPG key handling and apt sources configuration, and adds a new Ubuntu 24.04 PTL (Panther Lake) image template with DLS (DL Streamer) support. The changes move away from using signed-by directives in apt sources to a simpler format that relies on GPG keys placed in the global trusted keyring directory.
Changes:
- Modified apt sources generation to use simple format without signed-by directives
- Changed GPG key storage location from /usr/share/keyrings/ to /etc/apt/trusted.gpg.d/
- Added automatic GPG key dearmorming (ASCII to binary conversion)
- Added new Ubuntu 24.04 PTL image template with DLS packages
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
| internal/config/apt_sources.go | Removed signed-by directives from apt sources generation, changed GPG key paths to /etc/apt/trusted.gpg.d/, added dearmorGPGKey function, consolidated GPG key file creation logic, and added 0644 permissions to GPG key files |
| config/osv/ubuntu/ubuntu24/imageconfigs/additionalfiles/ubuntu-noble.list | Updated to simple deb line format without signed-by directives |
| image-templates/ubuntu24-x86_64-minimal-ptl-dls.yml | New image template for Ubuntu 24.04 PTL with DLS support including Docker, DL Streamer, and PTL-specific packages and configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
srmungar
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR
Description
Any Newly Introduced Dependencies
How Has This Been Tested?