Merged
Conversation
Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com>
Add zizmor-fix
Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com>
Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com>
Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com>
Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com>
* Update zizmor fix Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com> * Update zizmor fix Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com> * Revert trivy action Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com> --------- Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com>
* Update zizmor fix Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com> * Update zizmor fix Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com> * Revert trivy action Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com> * Update setup Earthly in unit test workflow Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com> --------- Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com>
Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com>
elvin03
requested review from
a team,
adimoft,
daveroge,
manilk1x and
shanedonohue
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements security fixes recommended by Zizmor, a GitHub Actions workflow security auditing tool. The changes pin all GitHub Actions to specific commit SHAs instead of mutable version tags, following security best practices to prevent supply chain attacks and ensure reproducible builds.
Changes:
- Replace version tag references (e.g.,
@v6.0.2) with commit SHA references plus version comments (e.g.,@de0fac2e4500dabe0009e67214ff5f5447ce83dd #v6.0.2) - Update 20 workflow files across build, test, and scanning workflows
- Apply consistent SHA pinning pattern for actions/checkout, actions/setup-go, earthly/actions-setup, docker/setup-buildx-action, and actions/upload-artifact
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 22 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/unit-test-and-coverage-gate.yml | Pin actions/checkout, earthly/actions-setup, and actions/upload-artifact to commit SHAs |
| .github/workflows/trivy-scan.yml | Pin actions/checkout to commit SHA |
| .github/workflows/go-lint.yml | Pin actions/checkout and actions/setup-go to commit SHAs |
| .github/workflows/gitleak-scan.yml | Pin actions/checkout to commit SHA |
| .github/workflows/build-ubuntu24-raw.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
| .github/workflows/build-ubuntu24-iso.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
| .github/workflows/build-ubuntu24-immutable.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
| .github/workflows/build-ubuntu24-dlstreamer.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
| .github/workflows/build-ubuntu24-arm-raw.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, actions/setup-go, and actions/upload-artifact to commit SHAs |
| .github/workflows/build-emt3-raw.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
| .github/workflows/build-emt3-iso.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
| .github/workflows/build-emt3-immutable.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
| .github/workflows/build-emt3-dlstreamer.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
| .github/workflows/build-elxr12-raw.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
| .github/workflows/build-elxr12-iso.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
| .github/workflows/build-elxr12-immutable.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
| .github/workflows/build-elxr12-dlstreamer.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
| .github/workflows/build-elxr12-arm-raw.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, actions/setup-go, and actions/upload-artifact to commit SHAs |
| .github/workflows/build-azl3-raw.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
| .github/workflows/build-azl3-iso.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
| .github/workflows/build-azl3-immutable.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
| .github/workflows/build-azl3-dlstreamer.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
| .github/workflows/build-azl3-arm-raw.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, actions/setup-go, and actions/upload-artifact to commit SHAs |
| .github/workflows/boot_tester.yml | Pin actions/checkout, docker/setup-buildx-action, earthly/actions-setup, and actions/setup-go to commit SHAs |
Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com>
Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR
Description
Add zizmor fix
Any Newly Introduced Dependencies
N/A
How Has This Been Tested?
Trigger GHA