Fixing package name with numeric issue in top level package resolving#456
Merged
Fixing package name with numeric issue in top level package resolving#456
Conversation
Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses RPM top-level package resolution for package names that contain numeric segments (e.g., ntfs-3g), by preferring the canonical RPM package name field instead of deriving the name from the RPM filename.
Changes:
- Update
ResolveTopPackageConflictsto usePackageInfo.PkgNamewhen matching requested package names, falling back to filename-based extraction whenPkgNameis empty.
samueltaripin
approved these changes
Mar 2, 2026
srmungar
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR
Description
Fixing package name with numeric issue in top level package resolving, currently, if the requested package name in template containing numeric, for example, "ntfs-3g", will be recognized as "ntfs", which is incorrect.
Any Newly Introduced Dependencies
How Has This Been Tested?