Skip to content

fix: Block update when instance is provisioned#11

Merged
pierventre merged 22 commits intomainfrom
block-lc-instance-update
May 23, 2025
Merged

fix: Block update when instance is provisioned#11
pierventre merged 22 commits intomainfrom
block-lc-instance-update

Conversation

@niket-intc
Copy link
Copy Markdown
Contributor

@niket-intc niket-intc commented Apr 2, 2025 •
edited by pierventre
Loading

PULL DESCRIPTION

Prevent LocalAccount update when the Instance is no more in the initial state

Impact Analysis

Info Please fill out this column
Root Cause Specifically for bugs, empty in case of no variants
Jira ticket ITEP-23276

CODE MAINTAINABILITY

  • Added required new tests relevant to the changes and the URL has been included
  • Updated Documentation as relevant to the changes
  • PR change contains code related to security
  • PR introduces changes that break compatibility with other modules/services (If YES, please provide description)

Code must act as a teacher for future developers

@niket-intc niket-intc requested a review from pierventre April 2, 2025 13:58
pierventre
pierventre reviewed Apr 2, 2025
View reviewed changes
Comment thread inventory/internal/store/instance.go Outdated
pierventre
pierventre reviewed Apr 2, 2025
View reviewed changes
Comment thread inventory/internal/store/instance.go Outdated
pierventre
pierventre reviewed Apr 2, 2025
View reviewed changes
Comment thread inventory/internal/store/instance_test.go
pierventre
pierventre reviewed Apr 3, 2025
View reviewed changes
Comment thread inventory/internal/store/instance.go Outdated
pierventre
pierventre reviewed Apr 3, 2025
View reviewed changes
Comment thread inventory/internal/store/instance.go Outdated
pierventre
pierventre reviewed Apr 15, 2025
View reviewed changes
Comment thread inventory/internal/store/instance.go Outdated
pierventre
pierventre reviewed Apr 15, 2025
View reviewed changes
Comment thread inventory/internal/store/instance.go Outdated
pierventre
pierventre reviewed Apr 15, 2025
View reviewed changes
Comment thread inventory/internal/store/instance_test.go
pierventre
pierventre reviewed Apr 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@pierventre pierventre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather merge this post-release

@pierventre
Copy link
Copy Markdown
Contributor

pierventre commented Apr 29, 2025

I dont see my commnets being addressed

@pierventre pierventre requested a review from krishnajs as a code owner May 22, 2025 19:13
@daniele-moro daniele-moro changed the title Block update when instance is provisioned fix: Block update when instance is provisioned May 23, 2025
@pierventre pierventre enabled auto-merge (squash) May 23, 2025 16:28
@pierventre pierventre disabled auto-merge May 23, 2025 18:24
@pierventre pierventre merged commit d3884e7 into main May 23, 2025
20 checks passed
@pierventre pierventre deleted the block-lc-instance-update branch May 23, 2025 18:28
@daniele-moro daniele-moro mentioned this pull request May 30, 2025
Merged
3 tasks
@rranjan3 rranjan3 mentioned this pull request May 30, 2025
Merged
3 tasks
raphaelvrosa pushed a commit that referenced this pull request Jun 6, 2025
@niket-intc @Paiadhithi @pierventre
fix: Block update when instance is provisioned (#11)
20c10a4 
Co-authored-by: Adhithi Pai B <adhithi.pai.b@intel.com>
Co-authored-by: pierventre <pier.ventre@intel.com>
Co-authored-by: Pier Luigi Ventre <5659115+pierventre@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierventre pierventre pierventre approved these changes

@Andrea-Campanella Andrea-Campanella Andrea-Campanella approved these changes

@cjnolan cjnolan Awaiting requested review from cjnolan cjnolan is a code owner

@damiankopyto damiankopyto Awaiting requested review from damiankopyto damiankopyto is a code owner

@ikyrycho ikyrycho Awaiting requested review from ikyrycho

@jkossak jkossak Awaiting requested review from jkossak

@ktaube26 ktaube26 Awaiting requested review from ktaube26

@osinstom osinstom Awaiting requested review from osinstom

@Paiadhithi Paiadhithi Awaiting requested review from Paiadhithi

@PalashGoelIntel PalashGoelIntel Awaiting requested review from PalashGoelIntel

@raphaelvrosa raphaelvrosa Awaiting requested review from raphaelvrosa

@rranjan3 rranjan3 Awaiting requested review from rranjan3 rranjan3 is a code owner

@soniabha-intc soniabha-intc Awaiting requested review from soniabha-intc soniabha-intc is a code owner

@sunil-parida sunil-parida Awaiting requested review from sunil-parida sunil-parida is a code owner

@tmatenko tmatenko Awaiting requested review from tmatenko

@zdw zdw Awaiting requested review from zdw

@krishnajs krishnajs Awaiting requested review from krishnajs krishnajs is a code owner

+1 more reviewer

@daniele-moro daniele-moro daniele-moro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

inventory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@niket-intc @pierventre @daniele-moro @Andrea-Campanella @Paiadhithi