Skip to content

Align CustomConfig API with inventy proto #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niket-intc merged 18 commits into from
Jun 12, 2025
Merged

Align CustomConfig API with inventy proto #266

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
5f64788
fix length and update cc to match inventory proto
niket-intc Jun 12, 2025
d91d73a
fix length and update cc to match inventory proto
niket-intc Jun 12, 2025
002a595
Updated api sepc
niket-intc Jun 12, 2025
26882df
Merge branch 'main' into cc-fix-list-unit32
Jun 12, 2025
8e6f2d2
bump version
Jun 12, 2025
113f537
bump version
Jun 12, 2025
cca0398
generated after fix
niket-intc Jun 12, 2025
6ac0b16
Merge branch 'cc-fix-list-unit32' of https://github.com/open-edge-pla…
niket-intc Jun 12, 2025
15bea84
Regenerate api
Jun 12, 2025
2cbf999
reverted and added pattern match
niket-intc Jun 12, 2025
a5e8543
Merge branch 'cc-fix-list-unit32' of https://github.com/open-edge-pla…
niket-intc Jun 12, 2025
40aab55
Regenerate api
Jun 12, 2025
df632e9
Merge branch 'main' into cc-fix-list-unit32
daniele-moro Jun 12, 2025
a2ee0eb
updated the config name
niket-intc Jun 12, 2025
838d062
Merge branch 'cc-fix-list-unit32' of https://github.com/open-edge-pla…
niket-intc Jun 12, 2025
204c606
Regenerate api
Jun 12, 2025
0c52510
Merge branch 'main' into cc-fix-list-unit32
niket-intc Jun 12, 2025
95cd305
add exception to .gitleaksignore
niket-intc Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apiv2/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.1.2
2.1.3
2 changes: 1 addition & 1 deletion apiv2/api/openapi/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4022,7 +4022,7 @@ components:
name:
type: string
title: name
maxLength: 32
maxLength: 40
pattern: ^[a-z][a-z0-9-]{0,31}$
description: Config provided by admin
description:
Expand Down
4 changes: 2 additions & 2 deletions apiv2/api/proto/resources/customconfig/v1/customconfig.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ message CustomConfigResource {
string name = 2 [
(buf.validate.field).string = {
pattern: "^[a-z][a-z0-9-]{0,31}$"
Comment thread
niket-intc marked this conversation as resolved.
max_len: 32
max_len: 40
},
(google.api.field_behavior) = REQUIRED
];
Expand All @@ -40,7 +40,7 @@ message CustomConfigResource {
(google.api.field_behavior) = OPTIONAL
];
// Config content
string config_content = 4 [
string config = 4 [
(buf.validate.field).string = {
max_len: 16384
},
Expand Down
2 changes: 1 addition & 1 deletion apiv2/internal/pbapi/resources/customconfig/v1/customconfig.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading