add models to model_converter with hf card templates#507
Open
add models to model_converter with hf card templates#507
Conversation
tybulewicz
reviewed
Mar 19, 2026
| # {model_name} | ||
|
|
||
| - Model creator: [timm](https://huggingface.co/timm) | ||
| - Original model: [timm/{model_name}](https://huggingface.co/timm/{model_name}) |
Contributor
There was a problem hiding this comment.
model_name differs from original name of the model (dot is replaced by underscode) - consider not changing original names, to make links correct
|
|
||
| ## Legal information | ||
|
|
||
| The original model is distributed under [Apache License 2.0](https://choosealicense.com/licenses/apache-2.0/) license. More details can be found in [timm/{model_name}](https://huggingface.co/timm/{model_name}). |
Contributor
There was a problem hiding this comment.
Are we sure that all TIMM models fall under apache 2.0? Maybe the license should be downloaded from HF metadata?
Contributor
Author
There was a problem hiding this comment.
add license name in model config
| # {model_name} | ||
|
|
||
| - Model creator: [torchvision](https://github.com/pytorch/vision) | ||
| - Original model: [{model_name}](https://github.com/pytorch/vision) |
Contributor
There was a problem hiding this comment.
Shouldn't we provide full link to the model? for example https://docs.pytorch.org/vision/main/models/generated/torchvision.models.resnet101.html
tybulewicz
reviewed
Mar 19, 2026
56e4a13 to
e07c858
Compare
tybulewicz
approved these changes
Mar 20, 2026
Contributor
tybulewicz
left a comment
There was a problem hiding this comment.
This works as a first version, to be refined later
AlexanderBarabanov
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Usage:
Before submitting