Conversation
…atches to prevent cross-package-type comparisons Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com>
Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com>
Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds target-aware candidate prioritization to prefer exact package-name matches over Provides matches during Debian package resolution, aimed at avoiding cross-package-type comparisons (e.g., kernel vs dkms).
Changes:
- Introduced
filterCandidatesByPriorityWithTargetto prefer exact name matches before comparing repository priority/version. - Updated
ResolveTopPackageConflictsandfindAllCandidatesto use the new target-aware filtering. - Fixed indentation in the Ubuntu 24 minimal raw image template package list.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| internal/ospackage/debutils/resolver.go | Adds target-aware candidate filtering/sorting and expands debug logging during resolution. |
| image-templates/ubuntu24-x86_64-minimal-raw.yml | YAML indentation adjustment for the packages list entry. |
arodage
reviewed
Apr 14, 2026
Signed-off-by: Teoh Suh Haw <suh.haw.teoh@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR
Description
New function added - prioritizes exact name matches over "provides" matches to prevent cross-package-type comparisons
Any Newly Introduced Dependencies
N/A
How Has This Been Tested?