Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: saratpoluri

controller/src/controller/uuid_manager.py

@@ -539,8 +539,9 @@ def _findBestMetricCandidate(self, entities):
     """
     Find the best candidate uuid and metric value according to descriptor semantics.
 
-    VDMS returns entities sorted ascending by _distance (closest first), so entities[0]
-    is always the best match.
+    The best match is selected from the provided entities based on the configured
+    descriptor metric semantics: higher values are better for higher-is-better
+    metrics, and lower values are better otherwise.
 
     Structure of entities:
     [{'uuid': <UUID>, 'rvid': <TRACKER_ID>, '_distance': <SIMILARITY_SCORE>}, ...]

controller/src/controller/vdms_adapter.py

@@ -259,10 +259,6 @@ def addEntry(self, uuid, rvid, object_type, reid_vectors, set_name=SCHEMA_NAME,
       log.warning("addEntry: No valid vectors to add (all skipped due to dimension mismatch or uninitialized dimensions)")
       return
 
-    if len(add_query) == 0:
-      log.warning("addEntry: No valid vectors to add")
-      return
-
     response, _ = self.sendQuery(add_query, descriptor_blobs)  # Flat list of blobs
     if response:
       success_count = 0

docs/user-guide/other-topics/how-to-enable-reidentification.md

@@ -149,12 +149,12 @@ The scene output includes `reid_state` for each tracked object. For canonical st
 
 ## Configuration Options
 
-| Parameter                        | Purpose                                                                                                                                                 | Expected Value/Range               |
-| -------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------- |
-| `DEFAULT_SIMILARITY_THRESHOLD`   | Minimum Inner Product metric value for a match to be accepted. Higher values are stricter; lower values increase recall (and possible false positives). | Float metric value (e.g., 0.2–0.8) |
-| `DEFAULT_MINIMUM_BBOX_AREA`      | Minimum bounding box size to consider a valid feature.                                                                                                  | Pixel area (e.g., 400–1600)        |
-| `DEFAULT_MINIMUM_FEATURE_COUNT`  | Minimum features needed before querying DB.                                                                                                             | Integer (e.g., 5–20)               |
-| `DEFAULT_MAX_FEATURE_SLICE_SIZE` | Proportion of features stored to improve DB performance.                                                                                                | Float (e.g., 0.1–1.0)              |
+| Parameter                        | Purpose                                                                                                                                                                                            | Expected Value/Range                                                   |
+| -------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------- |
+| `DEFAULT_SIMILARITY_THRESHOLD`   | Match-acceptance threshold. Interpretation depends on `similarity_metric`: for `COSINE` (mapped to VDMS `IP`), higher values are stricter; for `L2`, lower values are stricter.                  | Float; tune per metric. For `COSINE`/`IP`, values such as `0.2–0.8` may be used. For `L2`, use a distance threshold appropriate to the embedding/model. |
+| `DEFAULT_MINIMUM_BBOX_AREA`      | Minimum bounding box size to consider a valid feature.                                                                                                                                             | Pixel area (e.g., 400–1600)                                            |
+| `DEFAULT_MINIMUM_FEATURE_COUNT`  | Minimum features needed before querying DB.                                                                                                                                                        | Integer (e.g., 5–20)                                                   |
+| `DEFAULT_MAX_FEATURE_SLICE_SIZE` | Proportion of features stored to improve DB performance.                                                                                                                                           | Float (e.g., 0.1–1.0)                                                  |
 
 To apply changes (include `--profile vdms` if ReID is enabled; see [Docker Compose Profiles](../get-started.md#docker-compose-profiles)):
 

tests/Makefile.sscape

@@ -52,6 +52,8 @@ django-integration-unit:
 	$(MAKE) -Otarget -j $(NPROCS) _$@ SECRETSDIR=$(SECRETSDIR) SUPASS=$(SUPASS) -k
 	$(eval SECRETSDIR := $(OLDSECRETSDIR))
 
+logic-unit-tests:
+	$(MAKE) -Otarget -j $(NPROCS) _$@ SUPASS=$(SUPASS) -k
 _logic-unit-tests: \
 	autocamcalib-unit \
 	geometry-unit \