Indicate if camera bounds are projected#1285
Merged
saratpoluri merged 13 commits intomainfrom Apr 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SceneScape’s detection/tracking data formats by (1) removing the unused center_of_mass field across schemas, docs, and test fixtures, and (2) augmenting tracked-object camera_bounds with a projected boolean to indicate whether bounds are detector-provided (pass-through) or computed via projection.
Changes:
- Add
projectedflag to per-cameracamera_boundsemitted by the controller. - Remove
center_of_massfrom controller metadata schema and update associated docs and test data/fixtures. - Update DL Streamer gvapython policies and tracker/test payload generators to stop emitting/expecting
center_of_mass.
Reviewed changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tracker/test/load/simulate-detections.js | Removes center_of_mass from simulated detection messages. |
| tests/sscape_tests/schema/conftest.py | Updates schema test fixture to drop center_of_mass. |
| tests/sscape_tests/scene_pytest/config.py | Updates scene pytest config payloads to remove center_of_mass. |
| tests/security/malformed_data/README.md | Updates malformed-data examples to remove center_of_mass. |
| tests/security/malformed_data/baddata_json.txt | Updates malformed JSON corpus to remove center_of_mass. |
| scene_common/src/fast_geometry/bindings.cpp | Removes outdated comment referencing center_of_mass ROI. |
| docs/user-guide/microservices/controller/data_formats.md | Removes center_of_mass from documented fields and documents camera_bounds.projected with updated examples. |
| docs/user-guide/building-a-scene/how-to-configure-spatial-analytics.md | Removes center_of_mass from documented JSON examples. |
| dlstreamer-pipeline-server/user_scripts/gvapython/sscape/sscape_policies.py | Stops emitting center_of_mass (but currently drops 3D extra_params fields—see comments). |
| controller/tools/tracker/standard-tests.json | Removes center_of_mass from standard tracker test vectors. |
| controller/src/schema/metadata.schema.json | Removes center_of_mass definition and reference from schema. |
| controller/src/controller/scene.py | Removes deserialization of center_of_mass into tracked object info. |
| controller/src/controller/detections_builder.py | Adds camera_bounds[*].projected and improves selection between detector bbox vs projected bbox with debug logging. |
dlstreamer-pipeline-server/user_scripts/gvapython/sscape/sscape_policies.py
Outdated
Show resolved
Hide resolved
dlstreamer-pipeline-server/user_scripts/gvapython/sscape/sscape_policies.py
Show resolved
Hide resolved
daddo-intel
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR makes the following changes:
Fixes lingering tracks due to discarded update frames.
Adds a Boolean field to indicate if the camera bounds are projected or it is pass through.
Removes center of mass field which has been unused and does not add any value.
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: