Skip to content

Indicate if camera bounds are projected#1285

Merged
saratpoluri merged 13 commits intomainfrom
fix/visibility-bbox
Apr 10, 2026
Merged

Indicate if camera bounds are projected#1285
saratpoluri merged 13 commits intomainfrom
fix/visibility-bbox

Conversation

@saratpoluri
Copy link
Copy Markdown
Contributor

@saratpoluri saratpoluri commented Apr 8, 2026

📝 Description

This PR makes the following changes:
Fixes lingering tracks due to discarded update frames.
Adds a Boolean field to indicate if the camera bounds are projected or it is pass through.
Removes center of mass field which has been unused and does not add any value.

✨ Type of Change

Select the type of change your PR introduces:

  • 🐞 Bug fix – Non-breaking change which fixes an issue
  • 🚀 New feature – Non-breaking change which adds functionality
  • 🔨 Refactor – Non-breaking change which refactors the code base
  • 💥 Breaking change – Changes that break existing functionality
  • 📚 Documentation update
  • 🔒 Security update
  • 🧪 Tests
  • 🚂 CI

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

  • ✅ Tested manually
  • 🤖 Ran automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

  • 🔍 PR title is clear and descriptive
  • 📝 For internal contributors: If applicable, include the JIRA ticket number (e.g., ITEP-123456) in the PR title. Do not include full URLs
  • 💬 I have commented my code, especially in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ✅ I have added tests that prove my fix is effective or my feature works

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates SceneScape’s detection/tracking data formats by (1) removing the unused center_of_mass field across schemas, docs, and test fixtures, and (2) augmenting tracked-object camera_bounds with a projected boolean to indicate whether bounds are detector-provided (pass-through) or computed via projection.

Changes:

  • Add projected flag to per-camera camera_bounds emitted by the controller.
  • Remove center_of_mass from controller metadata schema and update associated docs and test data/fixtures.
  • Update DL Streamer gvapython policies and tracker/test payload generators to stop emitting/expecting center_of_mass.

Reviewed changes

Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tracker/test/load/simulate-detections.js Removes center_of_mass from simulated detection messages.
tests/sscape_tests/schema/conftest.py Updates schema test fixture to drop center_of_mass.
tests/sscape_tests/scene_pytest/config.py Updates scene pytest config payloads to remove center_of_mass.
tests/security/malformed_data/README.md Updates malformed-data examples to remove center_of_mass.
tests/security/malformed_data/baddata_json.txt Updates malformed JSON corpus to remove center_of_mass.
scene_common/src/fast_geometry/bindings.cpp Removes outdated comment referencing center_of_mass ROI.
docs/user-guide/microservices/controller/data_formats.md Removes center_of_mass from documented fields and documents camera_bounds.projected with updated examples.
docs/user-guide/building-a-scene/how-to-configure-spatial-analytics.md Removes center_of_mass from documented JSON examples.
dlstreamer-pipeline-server/user_scripts/gvapython/sscape/sscape_policies.py Stops emitting center_of_mass (but currently drops 3D extra_params fields—see comments).
controller/tools/tracker/standard-tests.json Removes center_of_mass from standard tracker test vectors.
controller/src/schema/metadata.schema.json Removes center_of_mass definition and reference from schema.
controller/src/controller/scene.py Removes deserialization of center_of_mass into tracked object info.
controller/src/controller/detections_builder.py Adds camera_bounds[*].projected and improves selection between detector bbox vs projected bbox with debug logging.

@saratpoluri saratpoluri marked this pull request as draft April 8, 2026 22:17
@saratpoluri saratpoluri marked this pull request as ready for review April 9, 2026 00:18
@saratpoluri saratpoluri requested a review from Copilot April 9, 2026 00:18
@saratpoluri saratpoluri enabled auto-merge (squash) April 9, 2026 00:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 16 changed files in this pull request and generated 2 comments.

@saratpoluri saratpoluri merged commit 0411ae3 into main Apr 10, 2026
28 of 29 checks passed
@saratpoluri saratpoluri deleted the fix/visibility-bbox branch April 10, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants