ITEP-89520: Sensor tagging for high performan tracker by daddo-intel · Pull Request #1308 · open-edge-platform/scenescape

daddo-intel · 2026-04-16T00:04:54Z

📝 Description

This PR enables sensor tagging with high performant tracker. To test:

Run make demo-tracker SUPASS=<password>
Create a sensor in scenescape 2D UI e.g sensor_0
docker exec into web container and run:

while true; do
  mosquitto_pub -h broker.scenescape.intel.com -p 1883 \
    --cafile /run/secrets/certs/scenescape-ca.pem \
    --insecure \
    -t "scenescape/data/sensor/sensor_0" \
    -m "{\"timestamp\":\"$(date -u +%Y-%m-%dT%H:%M:%S.%6NZ)\",\"subtype\":\"temperature\",\"id\":\"sensor_0\",\"value\":$((RANDOM % 100))}"
  sleep 1
done

In another terminal, docker exec into web container and run:

mosquitto_sub -h broker.scenescape.intel.com -p 1883 \
  --cafile /run/secrets/certs/scenescape-ca.pem \
  --insecure \
  -t "scenescape/regulated/scene/<scene-id>"

Verify that data in regulated topic has sensor values associated with track objects

To run test, run:
make -C tests sensors-send-events ANALYTICS=true SUPASS=<password>

✨ Type of Change

Select the type of change your PR introduces:

🐞 Bug fix – Non-breaking change which fixes an issue
🚀 New feature – Non-breaking change which adds functionality
🔨 Refactor – Non-breaking change which refactors the code base
💥 Breaking change – Changes that break existing functionality
📚 Documentation update
🔒 Security update
🧪 Tests
🚂 CI

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

✅ Tested manually
🤖 Ran automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

🔍 PR title is clear and descriptive
📝 For internal contributors: If applicable, include the JIRA ticket number (e.g., ITEP-123456) in the PR title. Do not include full URLs
💬 I have commented my code, especially in hard-to-understand areas
📄 I have made corresponding changes to the documentation
✅ I have added tests that prove my fix is effective or my feature works

ltalarcz

In review

…ging

saratpoluri · 2026-04-21T00:08:10Z

This is focused on environmental sensor only?

Copilot

Pull request overview

This PR adds support for sensor tagging when running the high-performance tracker in an analytics-only deployment, and updates functional tests/compose tooling to exercise that path.

Changes:

Add analytics-only tracked-object caching in the controller Scene to support associating sensor readings with tracker-published objects.
Extend the sensors-send-events functional test target to optionally run against a tracker + analytics-only controller compose stack (gated by ANALYTICS).
Update the sensor MQTT functional test to include pixel bboxes and relax assertions when running in analytics mode.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tools/scenescape-start	Pass through `ANALYTICS` env var into the started container.
tests/functional/tc_sensors_send_mqtt_messages.py	Add `bounding_box_px`, analytics flag handling, and adjust external-topic assertions for analytics runs.
tests/compose/tracker.yml	New tracker service compose file for functional tests.
tests/compose/controller_analytics.yml	New analytics-only controller compose file for functional tests.
tests/Makefile.functional	Add `ANALYTICS`-gated compose/service selection for `sensors-send-events`.
tests/Makefile	Propagate `ANALYTICS` into the test runner environment.
controller/src/controller/scene.py	Add analytics-only object caching/deserialization and adjust sensor processing to use analytics objects.

Copilot · 2026-04-21T00:13:53Z

+    if self.use_tracker:
+      for detectionType in self.tracker.trackers.keys():
+        for obj in self.tracker.currentObjects(detectionType):
+          # When tracking is disabled, do not rely on obj.frameCount being initialized
+          if (not self.use_tracker or obj.frameCount > 3) and (is_scene_wide or sensor.isPointWithin(obj.sceneLoc)):
+            objects_in_sensor.append(obj)
+            obj.chain_data.active_sensors.add(sensor_id)
+    else:
+      for obj in self._analytics_objects.values():
+        if is_scene_wide or sensor.isPointWithin(obj.sceneLoc):
          objects_in_sensor.append(obj)
-          # Ensure active_sensors is updated (handles scene-wide sensors or objects existing before sensor creation)
          obj.chain_data.active_sensors.add(sensor_id)


processSensorData() now branches on self.use_tracker. In non-analytics mode use_tracker can be False (see scene_data.get('use_tracker', True)), but self.tracker is still present and _analytics_objects is never populated (it’s only updated in ControllerMode.isAnalyticsOnly()). This means sensor tagging will silently stop working when tracking is disabled. Consider branching on ControllerMode.isAnalyticsOnly()/self.tracker is None instead, and still iterating self.tracker.currentObjects(...) when a tracker exists (keeping the frameCount gating only when use_tracker is True).

Copilot · 2026-04-21T00:13:53Z

+  django:
+    file: ${SECRETSDIR}/django
+  controller-auth-file:
+    file: manager/secrets/controller.auth


controller-auth-file is hardcoded to manager/secrets/controller.auth. Other test compose files use ${SECRETSDIR} for secrets (e.g., tests/compose/web.yml, tests/compose/scene.yml), which allows callers to override secrets location. Using a fixed relative path here can break runs that set SECRETSDIR to a non-default location; consider switching this to ${SECRETSDIR}/controller.auth for consistency.

Suggested change

file: manager/secrets/controller.auth

file: ${SECRETSDIR}/controller.auth

Copilot · 2026-04-21T00:13:54Z

+	$(if $(ANALYTICS),\
+		$(eval COMPOSE_FILES := $(COMPOSE)/dlstreamer/broker.yml:$(COMPOSE)/ntp.yml:$(COMPOSE)/pgserver.yml:$(COMPOSE)/tracker.yml:$(COMPOSE)/controller_analytics.yml:$(COMPOSE)/web.yml) \
+		$(eval SERVICES := 'pgserver web tracker controller-analytics'),\
+		$(eval COMPOSE_FILES := $(COMPOSE)/dlstreamer/broker.yml:$(COMPOSE)/ntp.yml:$(COMPOSE)/pgserver.yml:$(COMPOSE)/scene.yml:$(COMPOSE)/web.yml) \
+		$(eval SERVICES := 'pgserver web scene')\
+	)


Make’s $(if $(ANALYTICS), …) treats any non-empty value as true, so ANALYTICS=false would still select the analytics compose stack while the Python test interprets ANALYTICS as false. To avoid surprising behavior, consider explicitly checking for truthy values (e.g., only true/1) when selecting the compose files/services.

saratpoluri · 2026-04-21T00:19:16Z

+            obj.chain_data.active_sensors.add(sensor_id)
+    else:
+      for obj in self._analytics_objects.values():
+        if is_scene_wide or sensor.isPointWithin(obj.sceneLoc):


Not for this PR: I think it is odd that all of region, sensor, tripwires are just handled and operated on openly in our scene class. Think about creating a base class called "Analytic" and Region, Tripwire and Sensor derive from it and the process method is overridden in each.

Co-authored-by: Sarat Poluri <sarat.chandra.poluri@intel.com>

saratpoluri · 2026-04-21T00:26:09Z

-    self.tracked_objects_cache[detection_type] = objects
+    self.tracked_objects_cache[detection_type] = tracked_objects
+
+    if ControllerMode.isAnalyticsOnly():


Please verify if use_tracer and isAnalyticsOnly are redundant.

saratpoluri · 2026-04-21T00:42:01Z

    if ControllerMode.isAnalyticsOnly():
      if detection_type in self.tracked_objects_cache:
        cached_objects = self.tracked_objects_cache[detection_type]
        return self._deserializeTrackedObjects(cached_objects)


If I deserialize in updateTrackedObjects, do I need to deserialize here again?

saratpoluri · 2026-04-21T00:43:30Z

      obj.size = obj_data.get('size')
      obj.confidence = obj_data.get('confidence')
-      obj.frameCount = obj_data.get('frame_count', 0)
+      obj.frameCount = obj_data.get('frame_count', 4)  # > 3 so sensor/region checks pass


What is this?

daddo-intel · 2026-04-21T00:57:44Z

This is focused on environmental sensor only?

works for both attribute & environmental sensors

daddo-intel added 2 commits April 15, 2026 12:39

Update controller to handle sensor tagging with high performant tracker

a911fe6

Update deserializeTrackedObjects() function

01dc283

daddo-intel changed the title ~~Feature/itep 89520 analytics mode sensor tagging~~ ITEP-89520: Sensor tagging for high performan tracker Apr 16, 2026

Fix indentation

2a3a581

ltalarcz requested changes Apr 16, 2026

View reviewed changes

daddo-intel added 7 commits April 16, 2026 07:58

Merge branch 'main' into feature/ITEP-89520-analytics-mode-sensor-tag…

6ae6831

…ging

Merge branch 'main' into feature/ITEP-89520-analytics-mode-sensor-tag…

977fe7b

…ging

Merge branch 'main' into feature/ITEP-89520-analytics-mode-sensor-tag…

fa746cd

…ging

scope the stale check to only the detection type being update

94de8df

Add test case for testing sensor send events in analytics mode

6a20088

Add controller_analytics and tracker test yml files

2d5bdbf

Fix indentation

a118505

saratpoluri requested review from Copilot, dmytroye and saratpoluri April 21, 2026 00:06

Copilot started reviewing on behalf of saratpoluri April 21, 2026 00:07 View session

saratpoluri reviewed Apr 21, 2026

View reviewed changes

Comment thread tests/Makefile Outdated

update test_scene.py

2b07ae1

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Fix indentation in Makefile

2e178ba

saratpoluri reviewed Apr 21, 2026

View reviewed changes

Comment thread controller/src/controller/scene.py Outdated

Update controller/src/controller/scene.py

c92671f

Co-authored-by: Sarat Poluri <sarat.chandra.poluri@intel.com>

saratpoluri reviewed Apr 21, 2026

View reviewed changes

	file: manager/secrets/controller.auth
	file: ${SECRETSDIR}/controller.auth

Conversation

daddo-intel commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

✨ Type of Change

🧪 Testing Scenarios

✅ Checklist

Uh oh!

ltalarcz left a comment

Choose a reason for hiding this comment

Uh oh!

saratpoluri commented Apr 21, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

saratpoluri Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

daddo-intel Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

saratpoluri Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

saratpoluri Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

saratpoluri Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

daddo-intel commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

daddo-intel commented Apr 16, 2026 •

edited

Loading