ITEP-90808: Add cosine similarity as a configurable option by saratpoluri · Pull Request #1327 · open-edge-platform/scenescape

saratpoluri · 2026-04-24T06:04:38Z

📝 Description

Adds configurable similarity-metric semantics to the ReID flow so the controller can run either distance-style matching (e.g., L2) or cosine-style matching (implemented via VDMS Inner Product with normalized embeddings).

Changes:

Add metric-aware vector preparation (flattening, dimension checks, optional normalization) and similarity-score validation for IP/cosine paths.
Make UUID matching logic metric-aware (higher-is-better for IP, lower-is-better for L2) and add/expand unit + functional test coverage around the new behavior.
Update docs and functional test matrices to cover metric selection and threshold semantics.

✨ Type of Change

Select the type of change your PR introduces:

🐞 Bug fix – Non-breaking change which fixes an issue
🚀 New feature – Non-breaking change which adds functionality
🔨 Refactor – Non-breaking change which refactors the code base
💥 Breaking change – Changes that break existing functionality
📚 Documentation update
🔒 Security update
🧪 Tests
🚂 CI

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

✅ Tested manually
🤖 Ran automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

🔍 PR title is clear and descriptive
📝 For internal contributors: If applicable, include the JIRA ticket number (e.g., ITEP-123456) in the PR title. Do not include full URLs
💬 I have commented my code, especially in hard-to-understand areas
📄 I have made corresponding changes to the documentation
✅ I have added tests that prove my fix is effective or my feature works

Update agent instructions

Co-authored-by: Lukasz Talarczyk <lukasz.talarczyk@intel.com>

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…n the metrics dataset (#1304)

Adds “live region dwell time” to region-scoped object outputs (region data + region events) so consumers can see how long an object has been inside a region at publish time. Additionally, it updates the stability test to include memory leak checks.

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

)

Co-authored-by: scenescapecicd <sys_scenescape_ci@intel.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Sarat Poluri <sarat.chandra.poluri@intel.com> Co-authored-by: Tomasz Dorau <tomasz.dorau@intel.com>

…1139) VGGT outputs camera poses and depth in scale-ambiguous units, which cased: Incorrect mesh dimenstions incorrect pixels_per_meter in renderTopView Inconsistent scale compared to MapAnything This PR implements automatic metric scale for VGGT using known camera poses provided to` _processOutputs() and applies scale factor to: Camera translations world_points_from_depth world_points

saratpoluri · 2026-04-29T18:14:17Z

@copilot Address all code review comments.

…hresholds, metric-aware docs Agent-Logs-Url: https://github.com/open-edge-platform/scenescape/sessions/bb444c83-c20c-4ba3-ad9b-50fec7959314 Co-authored-by: saratpoluri <1325325+saratpoluri@users.noreply.github.com>

Copilot · 2026-04-29T18:21:09Z

@copilot Address all code review comments.

Addressed in commit 51481b8:

vdms_adapter.py:20 – Reverted SIMILARITY_METRIC default to "L2" so bare VDMSDatabase() no longer forces IP/normalization semantics.
vdms_adapter.py:53-60 and uuid_manager.py:531-570 – Added _IP_SCORE_TOLERANCE = 1e-6 epsilon to all IP score bounds checks (±(1.0 + 1e-6)) so float32 rounding from VDMS won't silently drop near-perfect matches.
reid-threshold-scenario.json:16-29 – Fixed COSINE threshold directionality: tight scenario now uses 0.99 (near-perfect cosine required → few matches → expect_exceed_max: true) and loose uses 0.01 (almost anything passes → many matches → expect_exceed_max: false).
Extended-ReID.md:222-235 – Tuning guidance for similarity_threshold is now metric-specific: for L2 (lower-is-better) increase to widen / decrease to tighten; for COSINE (higher-is-better) the direction is reversed.
Updated four unit tests that used bare VDMSDatabase() assuming IP default to explicitly pass similarity_metric="IP".

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

sarthakdeva-intel

LGTM!

saratpoluri and others added 30 commits April 11, 2026 01:28

TEP-90209: Tracked object contains re-id state and chain of object ids

ed87881

Add another state called reid_disabled

7115171

Fix unique-id-count logic and update tests

aa27bca

Apply copilot suggested changes to agent instructions

1548a94

Update agent instructions

Check re-id effectiveness with time chunking as well.

79c7a0f

Handle no match but not null detection id

9d698ac

Fix indent failures

7077093

Prettier fixes

be28ebb

Fix two failing sensor tests. (#1290)

b5e672e

Co-authored-by: Lukasz Talarczyk <lukasz.talarczyk@intel.com>

[CI/CD] Add login to DockerHub step for self-hosted runners (#1305)

8f3d25e

Missing test files

3afdc3a

Update .gitignore (#1307)

4ae8ecf

pip: bump django from 5.2.12 to 5.2.13 in /manager (#1296)

2b501ab

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[DLStreamer] Update to 2026.1.0-20260414-weekly-ubuntu24 (#1309)

adac212

pip: bump pytest from 9.0.2 to 9.0.3 in /.github/resources (#1303)

e3e9db4

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[ITEP-90163] [Tracker evaluation] Verify projecting camera accuracy o…

41fec6e

…n the metrics dataset (#1304)

Fix the reid-unique-count test failures

99cca96

Add bbox size as a configurable param

6409044

Remove two scenes from reid test to avoid cross-pollination

e06f17f

[DOCS] Restructure chapters - further alignment (#1291)

05453d3

Fix current CVEs (#1312)

280a9dc

[ITEP-90160] Fix Autocalibration Docker image size regression (#1316)

2ed30d1

pip: bump gdown from 5.2.1 to 5.2.2 in /autocalibration (#1318)

5d1665f

Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

ITEP-89462 Refactor and add UT for controller analytics functions (#1299

b33dce0

)

Fix documentation

f8ec3d4

Leverage feature slice size in controller

ae9bf5a

Update unique_id_count inside lock

40cce06

Copilot started work on behalf of saratpoluri April 29, 2026 18:14 View session

Copilot finished work on behalf of saratpoluri April 29, 2026 18:22

saratpoluri requested review from Copilot April 29, 2026 18:23

Copilot started reviewing on behalf of saratpoluri April 29, 2026 18:24 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread controller/src/controller/vdms_adapter.py Outdated

Comment thread controller/src/controller/vdms_adapter.py Outdated

Comment thread controller/src/controller/vdms_adapter.py Outdated

saratpoluri added 4 commits April 29, 2026 12:10

Additional code review fixes

694baf8

Fix code review comments

7a13c44

Merge branch 'main' into feature/support-cosine

422bccc

Merge branch 'main' into feature/support-cosine

4a18810

saratpoluri force-pushed the feature/support-cosine branch from a4c1815 to 36b018c Compare April 30, 2026 22:17

Fix for prettier-check

ede8800

saratpoluri force-pushed the feature/support-cosine branch 4 times, most recently from 3a4d702 to ef6a6c9 Compare April 30, 2026 22:57

Additional fixes

a29eda8

saratpoluri force-pushed the feature/support-cosine branch from ef6a6c9 to a29eda8 Compare April 30, 2026 23:02

saratpoluri added 3 commits April 30, 2026 16:14

Adjust ADRs

13dc87a

Fix unit test error

2799c0d

Merge branch 'main' into feature/support-cosine

6f197c3

rawatts10 approved these changes May 1, 2026

View reviewed changes

saratpoluri enabled auto-merge (squash) May 1, 2026 17:57

daddo-intel approved these changes May 2, 2026

View reviewed changes

saratpoluri merged commit bb3180d into main May 2, 2026
33 checks passed

saratpoluri deleted the feature/support-cosine branch May 2, 2026 00:03

sarthakdeva-intel reviewed May 4, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ITEP-90808: Add cosine similarity as a configurable option#1327

ITEP-90808: Add cosine similarity as a configurable option#1327
saratpoluri merged 68 commits into
mainfrom
feature/support-cosine

saratpoluri commented Apr 24, 2026 •

edited

Loading

Uh oh!

saratpoluri commented Apr 29, 2026

Uh oh!

Copilot AI commented Apr 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sarthakdeva-intel left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

saratpoluri commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

✨ Type of Change

🧪 Testing Scenarios

✅ Checklist

Uh oh!

saratpoluri commented Apr 29, 2026

Uh oh!

Copilot AI commented Apr 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sarthakdeva-intel left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

saratpoluri commented Apr 24, 2026 •

edited

Loading