[ITEP-91238] Fix: autocalibration updateMapProcessed fails with HTTP 400#1357
Closed
dmytroye wants to merge 3 commits into
Closed
[ITEP-91238] Fix: autocalibration updateMapProcessed fails with HTTP 400#1357dmytroye wants to merge 3 commits into
updateMapProcessed fails with HTTP 400#1357dmytroye wants to merge 3 commits into
Conversation
updateMapProcessed fails with HTTP 400
updateMapProcessed fails with HTTP 400updateMapProcessed fails with HTTP 400
saratpoluri
reviewed
May 1, 2026
Co-authored-by: Sarat Poluri <sarat.chandra.poluri@intel.com>
Contributor
|
With this PR merged: #1278, this won't be needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fix: autocalibration
updateMapProcessedfails with HTTP 400SceneSerializer.validate()introduced in #1337 unconditionally requirednamein all scene updates. Autocalibration'supdateMapProcessedsends only{'map_processed': <timestamp>}with noname, causing every markerless calibration to fail with a 400 after hloc feature export.Change: Guard the
namecheck by creation vs. partial-update context — requirenameonly when creating a scene; on partial updates, only validate it if it was actually provided in the request.✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: