Skip to content

[ITEP-91238] Fix: autocalibration updateMapProcessed fails with HTTP 400#1357

Closed
dmytroye wants to merge 3 commits into
mainfrom
fix-autocalibration-markerless
Closed

[ITEP-91238] Fix: autocalibration updateMapProcessed fails with HTTP 400#1357
dmytroye wants to merge 3 commits into
mainfrom
fix-autocalibration-markerless

Conversation

@dmytroye
Copy link
Copy Markdown
Member

@dmytroye dmytroye commented Apr 30, 2026

📝 Description

Fix: autocalibration updateMapProcessed fails with HTTP 400

SceneSerializer.validate() introduced in #1337 unconditionally required name in all scene updates. Autocalibration's updateMapProcessed sends only {'map_processed': <timestamp>} with no name, causing every markerless calibration to fail with a 400 after hloc feature export.

Change: Guard the name check by creation vs. partial-update context — require name only when creating a scene; on partial updates, only validate it if it was actually provided in the request.

✨ Type of Change

Select the type of change your PR introduces:

  • 🐞 Bug fix – Non-breaking change which fixes an issue
  • 🚀 New feature – Non-breaking change which adds functionality
  • 🔨 Refactor – Non-breaking change which refactors the code base
  • 💥 Breaking change – Changes that break existing functionality
  • 📚 Documentation update
  • 🔒 Security update
  • 🧪 Tests
  • 🚂 CI

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

  • ✅ Tested manually
  • 🤖 Ran automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

  • 🔍 PR title is clear and descriptive
  • 📝 For internal contributors: If applicable, include the JIRA ticket number (e.g., ITEP-123456) in the PR title. Do not include full URLs
  • 💬 I have commented my code, especially in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ✅ I have added tests that prove my fix is effective or my feature works

@dmytroye dmytroye changed the title Fix marker less autocalibration Fix: autocalibration updateMapProcessed fails with HTTP 400 Apr 30, 2026
@dmytroye dmytroye marked this pull request as ready for review April 30, 2026 10:20
@dmytroye dmytroye changed the title Fix: autocalibration updateMapProcessed fails with HTTP 400 [ITEP-91238] Fix: autocalibration updateMapProcessed fails with HTTP 400 Apr 30, 2026
Comment thread manager/src/manager/serializers.py Outdated
Co-authored-by: Sarat Poluri <sarat.chandra.poluri@intel.com>
@saratpoluri
Copy link
Copy Markdown
Contributor

saratpoluri commented May 1, 2026

With this PR merged: #1278, this won't be needed.

@saratpoluri saratpoluri closed this May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants