ITEP- 91475: Fix REID schema initialization failure#1412
Open
daddo-intel wants to merge 11 commits intomainfrom
Open
ITEP- 91475: Fix REID schema initialization failure#1412daddo-intel wants to merge 11 commits intomainfrom
daddo-intel wants to merge 11 commits intomainfrom
Conversation
ltalarcz
reviewed
May 8, 2026
Co-authored-by: Lukasz Talarczyk <lukasz.talarczyk@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the controller’s VDMS ReID schema initialization to avoid a known failure mode when probing schema metadata, and adds/extends tests around SceneController publishing behavior and ROI (DATA_REGION) functional expectations.
Changes:
- Refactors VDMS schema initialization to attempt
AddDescriptorSetfirst and only probe metadata on non-success responses. - Hardens
sendQuery()response parsing to tolerate unexpected non-dict payloads. - Adds new unit tests for
SceneControllerpublish paths and strengthens functional ROI validation to require repeated non-emptyDATA_REGIONupdates while an object remains inside a region.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/sscape_tests/scenescape/test_scene_controller.py | Adds unit tests covering publishDetections and related publish* methods (scene/regulated/region/external). |
| tests/functional/tc_mqtt_sensor_roi.py | Updates ROI sensor functional flow to track in-region state for validating DATA_REGION update behavior. |
| tests/functional/common_scene_obj.py | Subscribes to DATA_REGION and adds assertions to validate repeated non-empty region updates while inside ROI. |
| controller/src/controller/vdms_adapter.py | Changes VDMS schema initialization flow (attempt-first creation) and makes sendQuery() more defensive. |
Contributor
|
@copilot Fix all code review comments |
Agent-Logs-Url: https://github.com/open-edge-platform/scenescape/sessions/18a69df5-bc55-4422-89cd-479befdc76a0 Co-authored-by: saratpoluri <1325325+saratpoluri@users.noreply.github.com>
Contributor
Implemented all outstanding review feedback in commit 4f67c5f.
UI screenshot: N/A (no UI changes in this update). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR updates the controller’s VDMS ReID schema initialization to avoid a known failure mode when probing schema metadata, and adds/extends tests around SceneController publishing behavior and ROI (DATA_REGION) functional expectations.
Changes:
Refactors VDMS schema initialization to attempt AddDescriptorSet first and only probe metadata on non-success responses.
Hardens sendQuery() response parsing to tolerate unexpected non-dict payloads.
Adds new unit tests for SceneController publish paths and strengthens functional ROI validation to require repeated non-empty DATA_REGION updates while an object remains inside a region.
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: