ITEP-81092: Added mapping service to helm deployment#589
ITEP-81092: Added mapping service to helm deployment#589saratpoluri merged 15 commits intorelease-2025.2from
Conversation
…b.com/open-edge-platform/scenescape into mapping_service_helm_chart_deployment
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a new mapping service to the Helm deployment, configured to be disabled by default. The changes include creating deployment, service, and certificate templates for the mapping service, along with necessary configuration values and integration points.
Key Changes:
- Added Helm templates for mapping service deployment, service, and certificate resources
- Integrated mapping service URL into web-app deployment when enabled
- Standardized image reference format in cluster-analytics deployment
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| kubernetes/scenescape-chart/values.yaml | Adds configuration values for the mapping service (disabled by default) |
| kubernetes/scenescape-chart/templates/mapping/deployment.yaml | Creates deployment template for mapping service with security contexts and volume mounts |
| kubernetes/scenescape-chart/templates/mapping/service.yaml | Defines Kubernetes service and optional load balancer for mapping service |
| kubernetes/scenescape-chart/templates/mapping/certificate.yaml | Configures TLS certificate for mapping service |
| kubernetes/scenescape-chart/templates/web-app/deployment.yaml | Adds conditional mapping service URL environment variable |
| kubernetes/scenescape-chart/templates/_helpers.tpl | Includes mapping service certificate in shared certs volume |
| kubernetes/scenescape-chart/templates/cluster-analytics/deployment.yaml | Fixes image reference format and renames pullPolicy to imagePullPolicy |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| mapping: | ||
| enabled: false | ||
| image: intel/scenescape-mapping | ||
| pullPolicy: IfNotPresent |
There was a problem hiding this comment.
The image reference format is inconsistent with other services in the deployment. For consistency with the cluster-analytics service (which uses separate repository and image fields), consider following the same pattern or explicitly including the full registry path if intentionally different.
| apiVersion: cert-manager.io/v1 | ||
| kind: Certificate | ||
| metadata: | ||
| name: {{ .Release.Name }}-mapping-cert |
There was a problem hiding this comment.
The certificate resource is not conditionally created based on .Values.mapping.enabled. Unlike deployment.yaml and service.yaml which check this flag, this certificate will always be created even when the mapping service is disabled. Add {{- if .Values.mapping.enabled }} at line 5 and {{- end }} at the end of the file.
| - secret: | ||
| name: {{ .Release.Name }}-mapping-tls | ||
| items: | ||
| - key: tls.key | ||
| path: scenescape-mapping.key | ||
| - key: tls.crt | ||
| path: scenescape-mapping.crt |
There was a problem hiding this comment.
The mapping certificate secret is unconditionally added to the shared certs volume, but the certificate itself may not exist when mapping is disabled. This will cause volume mount failures. Wrap this secret reference in a conditional check: {{- if .Values.mapping.enabled }}.
eaa904c to
cdfdeca
Compare
Co-authored-by: Jakub Sikorski <jakub.sikorski@intel.com>
📝 Description
Added mapping service to helm deployyment. It's disabled by default.
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: