-
Notifications
You must be signed in to change notification settings - Fork 451
[feature-v3] Move rest of OTX under native backend. Change structure of the folders. #4408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature-v3] Move rest of OTX under native backend. Change structure of the folders. #4408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the efforts! I have some minor comments.
I couldn't comment on the file but I have concerns about src/otx/types/label.py
. The types here are specific to the native backend. Maybe we can have backend.native.types
?
We use LableInfo for our datumaro datasets. Our datasets will be shared across all backends. So, I would rather keep labels.py in the base "types" folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor picky comments but feel free to ignore
src/otx/backend/native/models/instance_segmentation/__init__.py
Outdated
Show resolved
Hide resolved
I agree. I think we should move code from exporter outside specific backends to something like model_converter. I have a different question.
Why is samplers in models directory ? Wouldn't it be common for all backends which can perform training ? |
|
Agree that samplers can be moved out from models |
Samplers are moved under data folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reorganizes the OTX repository by moving existing OTX modules under a new backend/native
folder, refactoring core and algo directories, and updating all import paths accordingly. It also removes outdated developer guides and example notebooks.
- Moves OTX modules into
otx/backend/native
and adjusts folder hierarchy - Removes legacy
for_developers
guides and Jupyter notebook - Updates import statements across documentation and code to reflect new module paths
Reviewed Changes
Copilot reviewed 732 out of 732 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
for_developers/dir_structure.md | Deleted outdated directory-structure guide |
for_developers/contribution_guide.md | Deleted outdated contribution guide |
for_developers/add_custom_model.ipynb | Deleted example notebook |
docs/source/.../how_to_train/*.rst | Updated import paths for SubsetConfig and OTXDataModule |
docs/source/.../advanced/*.rst | Updated imports to otx.backend.native for models, callbacks, schedulers |
docs/source/.../get_started/*.rst | Updated imports from otx.core.* to new top-level and backend paths |
docs/source/.../explanation/additional_features/*.rst | Updated imports for config, data, samplers, callbacks |
docker/download_pretrained_weights.py | Updated instantiator import path |
Comments suppressed due to low confidence (2)
for_developers/dir_structure.md:1
- The developer directory-structure guide was removed in this PR; please add or point to an updated guide reflecting the new
otx/backend/native
hierarchy so developers can reference the current layout.
entire file removed
for_developers/contribution_guide.md:1
- The contribution guide has been deleted; ensure there is a replacement that explains the proposal and review process under the new structure to onboard contributors smoothly.
entire file removed
bdaef0c
into
open-edge-platform:feature-v3
Summary
New structure:
New structure:
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.