Skip to content

Use cuda 12.8 #4409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

ashwinvaidya17
Copy link
Contributor

@ashwinvaidya17 ashwinvaidya17 commented Jun 6, 2025

Summary

  • Add index url for cuda 12.8 and xpu
  • Now, the dependencies need to be specified as uv pip install -e .[cuda] or uv pip install -e .[xpu]

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2025 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM BUILD labels Jun 6, 2025
@ashwinvaidya17 ashwinvaidya17 marked this pull request as draft June 6, 2025 10:00
@ashwinvaidya17 ashwinvaidya17 marked this pull request as ready for review June 6, 2025 11:59
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
@@ -68,6 +67,12 @@ dev = [
"onnxruntime==1.21.1",
]

cuda = ["torch==2.7.0"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having introduced a new installation target, we need to update install instructions in the docs accordingly

@sovrasov
Copy link
Member

Just tested torch+cu12_8 installation locally: it works for slightly outdated drivers (built for CUDA12.6). It looks like the PR doesn't brake at least CUDA12.x compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUILD DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants