-
Notifications
You must be signed in to change notification settings - Fork 451
[feature-v3] Remove T_* data entities #4412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature-v3] Remove T_* data entities #4412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the copilot stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the legacy T_* data entity types by replacing them with the new OTXDataItem and related types, streamlining and modernizing type annotations and API references across the codebase. Key changes include updating test fixtures and type signatures in unit/integration tests, revising collate functions and error messages in tile-related code, and adapting backend model interfaces accordingly.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
tests/unit/data/entity/test_utils.py | Replaced OTXBatchDataEntity with OTXDataBatch and updated tensor dtypes |
tests/unit/data/entity/test_base.py | Updated type annotations to use OTXDataItem and adjusted dtype checks |
tests/unit/data/entity/conftest.py | Modified fixtures to return OTXDataItem instead of OTXDataEntity |
tests/integration/api/test_xai.py | Removed references to OTXBatchPredEntity, keeping only OTXPredBatch |
src/otx/types/types.py | Updated DATA type and replaced T_OTXDataEntity with OTXDataItem |
src/otx/data/transform_libs/torchvision.py | Changed type for results_cache from OTXDataEntity to OTXDataItem |
src/otx/data/entity/utils.py | Updated pytree registration type to OTXDataItem |
src/otx/data/entity/tile.py | Revised entity type annotations and error messages in collate and unbind methods |
src/otx/data/dataset/tile.py and src/otx/data/dataset/base.py | Updated return types and function signatures to use OTXDataItem instead |
src/otx/backend/* | Adapted backend model methods and type signatures accordingly |
258db4b
into
open-edge-platform:feature-v3
Summary
Remove the rest of the old OTX Data Entities
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.