Skip to content

Fetch the image as a blob before loading to properly handle CORS #5430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpggvilaca wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fetch the image as a blob before loading to properly handle CORS #5430

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6d0223
Fetch the image as a blob before loading to properly handle CORS
jpggvilaca Feb 5, 2026
efe54ad
Update error message
jpggvilaca Feb 5, 2026
4c1d48e
Remove test conditional
jpggvilaca Feb 6, 2026
d5bde9b
Merge branch 'develop' into jvilaca/fix-media-loading-issue
leoll2 Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions application/ui/src/features/annotator/tools/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,22 +348,32 @@ export const getRelativePoint = (element: ElementType, point: Point, zoom: numbe
};
};

export const loadImage = (link: string): Promise<HTMLImageElement> =>
new Promise<HTMLImageElement>((resolve, reject) => {
const image = new Image();
image.crossOrigin = 'anonymous';
export const loadImage = async (link: string): Promise<HTMLImageElement> => {
// Fetch as blob first to avoid CORS issues with cached images
const response = await fetch(link, { credentials: 'include' });
if (!response.ok) {
throw new Error(`Failed to load image from ${link}: ${response.status} ${response.statusText}`);
}

image.onload = () => resolve(image);
image.onerror = (error) => reject(error);
const blob = await response.blob();
const objectUrl = URL.createObjectURL(blob);

image.fetchPriority = 'high';
image.src = link;
return new Promise<HTMLImageElement>((resolve, reject) => {
const image = new Image();

if (process.env.NODE_ENV === 'test') {
// Immediately load the media item's image
image.onload = () => {
URL.revokeObjectURL(objectUrl);
resolve(image);
}
};
image.onerror = (error) => {
URL.revokeObjectURL(objectUrl);
reject(error);
};

image.fetchPriority = 'high';
image.src = objectUrl;
});
};

const drawImageOnCanvas = (img: HTMLImageElement, filter = ''): HTMLCanvasElement => {
const canvas: HTMLCanvasElement = document.createElement('canvas');
Expand Down
Loading