Open
Conversation
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
github-actions
bot
added
TEST
Docker Image SizesCPU
GPU
XPU
|
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
📊 Test coverage report
|
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
…kalinin/logs-feature-tests
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds automated coverage for the new Training Logs feature introduced in #5547, spanning Playwright e2e flows (jobs + models) and React component tests for the log viewer UI.
Changes:
- Add Playwright e2e specs for streaming (job) logs and historical (model) logs dialogs.
- Add component tests for
LogViewerandLogEntry, plus test infra updates (router render wrapper + missing DOM observer mock). - Extend MSW/fixture defaults and log-entry mocks to support logs endpoints and realistic log payloads.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| application/ui/tests/training-logs/training-logs-dialog.spec.ts | New e2e coverage for training logs dialog (SSE + REST cases). |
| application/ui/tests/models/models.spec.ts | Adds e2e coverage for opening/closing model training logs and error handling. |
| application/ui/tests/models/models-page.ts | Adds page-object helpers for targeting a specific model and interacting with logs dialog. |
| application/ui/tests/jobs/jobs.spec.ts | Updates jobs e2e coverage to include “View logs” button and dialog open/close flow. |
| application/ui/tests/jobs/jobs-page.ts | Adds page-object helpers for “View logs” button and logs dialog controls. |
| application/ui/tests/fixtures.ts | Adds default MSW handlers for job logs SSE and model logs REST endpoints. |
| application/ui/src/test-utils/render.tsx | Changes RTL render to enable rerendering by recreating the router via a wrapper. |
| application/ui/src/setup-tests.ts | Adds a jsdom IntersectionObserver mock. |
| application/ui/src/features/models/training-logs/log-viewer.component.test.tsx | New component tests for filtering, search, empty states, and connection status. |
| application/ui/src/features/models/training-logs/log-entry.component.test.tsx | New component tests for formatting and display of individual log entries. |
| application/ui/src/features/models/training-logs/hooks/use-model-logs.hook.ts | Tweaks error handling to throw based on response.ok. |
| application/ui/mocks/mock-log-entry.ts | Adds createMockLogs() helper to generate realistic test log arrays. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
54
to
64
| export const render = (ui: ReactNode, options: RenderOptions = {}) => { | ||
| const testQueryClient = options.queryClient ?? createQueryClient(); | ||
| const router = createTestRouter(ui, options, testQueryClient); | ||
|
|
||
| return rtlRender(<RouterProvider router={router} />); | ||
| const Wrapper = ({ children }: { children: ReactNode }) => { | ||
| const router = createTestRouter(children, options, testQueryClient); | ||
|
|
||
| return <RouterProvider router={router} />; | ||
| }; | ||
|
|
||
| return rtlRender(ui, { wrapper: Wrapper, ...options }); | ||
| }; |
There was a problem hiding this comment.
{ wrapper: Wrapper, ...options } allows options.wrapper to override the required router/TestProviders wrapper, which can silently break tests if a caller passes a wrapper (or spreads an options object that includes one). Consider spreading options first and forcing wrapper: Wrapper last, and/or omitting non-RTL options (route/path/queryClient) from what you pass into rtlRender.
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
Signed-off-by: Dmitry Kalinin <dmitry.kalinin@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added e2e and component tests for the log feature
Depends on #5547
How to test
Checklist