refactor(www): dogfood framework i18n path math; delete orphaned dev server - #519
Merged
Conversation
…orphaned v0.26-era dev server
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Deploying openelement with
|
| Latest commit: |
40927ff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a00b9631.lessjs.pages.dev |
| Branch Preview URL: | https://dev.lessjs.pages.dev |
Contributor
|
APIError: Insufficient Balance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logic-level hand-roll audit of www (follow-up to the theme-token sweep). Findings and actions: (1) www route declarations use the sanctioned tagName + OpenElement class contract read by the adapter route-scanner — not hand-rolled routing, no change needed; (2) open-layout.tsx hand-rolled locale path math (private detectLocale/parsePathWithoutLocale/localizePath/switchPath) duplicated the framework's runtime-safe i18n helpers — migrated to normalizeLocalePath from @openelement/app/i18n, keeping the site's canonical default-unprefixed scheme; (3) www/app/dev-server.ts + middleware/dev-static.ts were orphaned v0.26-era dev:fast leftovers with zero task/doc references — deleted (215 lines); (4) search-index.json is already generated by the adapter content/nav plugin — no change. Verification: www tests 26/26, full suite 946/946, deno task build + artifact truth green, i18n-locale e2e 12/12 in real Chromium (locale switch, zh rendering, dual-locale SSG output), theme-token gate green.