Skip to content

Fix windows compatibility and other small changes - #357

Merged
tgilon merged 10 commits into
masterfrom
fix/windows-compatibility
Jan 8, 2026
Merged

Fix windows compatibility and other small changes#357
tgilon merged 10 commits into
masterfrom
fix/windows-compatibility

Conversation

@coroa

@coroa coroa commented Jan 5, 2026

Copy link
Copy Markdown
Member

Changes proposed in this Pull Request

I split this out from #333 . These cover small changes that helped my tests and made everything more robust.

The largest changes in terms of line counts were that it specifies mandatory line endings for all files (all text files should have only LF endings, except for bat files which need CRLF) and then enforces them.

Leading to all the configtables and the few data changes.

If you hide whitespace diffs in github, the diff looks quite sane, actually :)

@coroa coroa mentioned this pull request Jan 5, 2026
12 tasks
@tgilon
tgilon self-requested a review January 6, 2026 14:18
@tgilon tgilon added this to the Release v0.5 milestone Jan 6, 2026

@tgilon tgilon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm wondering if it makes sense to contribute the .gitattributes changes upstream. I think it does, as it standardises things.

I also think that this PR could further standardise retrievals, since sb.smk doesn't consistently use the storage clause for its inputs.

Comment thread .gitattributes
Comment thread scripts/sb/retrieve_tyndp_bundle.py Outdated
Comment thread rules/common.smk
Comment thread .gitattributes

@tgilon tgilon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also makes sense to add a release note, even though the PR is small.

@coroa
coroa force-pushed the fix/windows-compatibility branch from 58e0a9d to de8ca36 Compare January 7, 2026 13:25
@coroa

coroa commented Jan 7, 2026

Copy link
Copy Markdown
Member Author

I also think that this PR could further standardise retrievals, since sb.smk doesn't consistently use the storage clause for its inputs.

I agree it could, but then all the other retrievals are for non-zenodo stuff which falls back to the default snakemake http storage plugin, which is not great. So let's not spend any time on that now.

@coroa
coroa force-pushed the fix/windows-compatibility branch from 2d9d19a to e87790f Compare January 7, 2026 13:35

@coroa coroa left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, addressed everything, i think.

Comment thread .gitattributes
Comment thread rules/common.smk
Comment thread rules/common.smk

@tgilon tgilon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just add a release note before merging. Otherwise, looks good, thank you @coroa !

@tgilon

tgilon commented Jan 8, 2026

Copy link
Copy Markdown
Member

As reported in PyPSA/powerplantmatching#276, powerplantmatching has retrieval issues. Local tests passed with 25b4f31.

@tgilon
tgilon merged commit 19cd028 into master Jan 8, 2026
4 of 5 checks passed
@tgilon
tgilon deleted the fix/windows-compatibility branch January 8, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants