Fix windows compatibility and other small changes - #357
Conversation
tgilon
left a comment
There was a problem hiding this comment.
Looks good! I'm wondering if it makes sense to contribute the .gitattributes changes upstream. I think it does, as it standardises things.
I also think that this PR could further standardise retrievals, since sb.smk doesn't consistently use the storage clause for its inputs.
tgilon
left a comment
There was a problem hiding this comment.
It also makes sense to add a release note, even though the PR is small.
58e0a9d to
de8ca36
Compare
I agree it could, but then all the other retrievals are for non-zenodo stuff which falls back to the default snakemake http storage plugin, which is not great. So let's not spend any time on that now. |
2d9d19a to
e87790f
Compare
coroa
left a comment
There was a problem hiding this comment.
Ok, addressed everything, i think.
|
As reported in PyPSA/powerplantmatching#276, |
Changes proposed in this Pull Request
I split this out from #333 . These cover small changes that helped my tests and made everything more robust.
The largest changes in terms of line counts were that it specifies mandatory line endings for all files (all text files should have only LF endings, except for bat files which need CRLF) and then enforces them.
Leading to all the configtables and the few data changes.
If you hide whitespace diffs in github, the diff looks quite sane, actually :)