Skip to content

fix: 7 - define inflow_t before branch so it is always assigned #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-rdt merged 3 commits into from
Jul 7, 2026
Merged

fix: 7 - define inflow_t before branch so it is always assigned #777

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9837f8
fix: define inflow_t before branch so it is always assigned
daniel-rdt Jul 2, 2026
1587451
doc: add release note
daniel-rdt Jul 2, 2026
f2c1018
Merge branch 'master' into fix/security-fix-7
daniel-rdt Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ Upcoming Open-TYNDP Release

**Bugfixes and Compatibility**

* Ensure ``inflow_t`` is always defined in ``attach_hydro``, resolving a pylint use-before-assignment issue (https://github.com/open-energy-transition/open-tyndp/pull/777).
Comment thread
daniel-rdt marked this conversation as resolved.
Outdated

**Documentation**

* Update benchmarking documentation tables and figures for v0.7.1 (https://github.com/open-energy-transition/open-tyndp/pull/711).
Expand Down
3 changes: 2 additions & 1 deletion scripts/add_electricity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,6 +820,7 @@ def attach_hydro(
country = ppl["bus"].map(n.buses.country).rename("country")

inflow_idx = ror.index.union(hydro.index)
inflow_t = pd.DataFrame()
if not inflow_idx.empty:
dist_key = ppl.loc[inflow_idx, "p_nom"].groupby(country).transform(normed)

Expand Down Expand Up @@ -853,7 +854,7 @@ def attach_hydro(
capital_cost=costs.at["ror", "capital_cost"],
weight=ror["p_nom"],
p_max_pu=(
inflow_t[ror.index] # pylint: disable=E0606
inflow_t[ror.index]
.divide(ror["p_nom"], axis=1)
.where(lambda df: df <= 1.0, other=1.0)
),
Expand Down