Skip to content

fix: 11 - add validation of Zenodo API URL and deposition_id - #780

Merged
daniel-rdt merged 8 commits into
masterfrom
fix/security-fix-8
Jul 8, 2026
Merged

fix: 11 - add validation of Zenodo API URL and deposition_id#780
daniel-rdt merged 8 commits into
masterfrom
fix/security-fix-8

Conversation

@daniel-rdt

@daniel-rdt daniel-rdt commented Jul 3, 2026

Copy link
Copy Markdown
Member

Changes proposed in this Pull Request

This PR proposes to add missing validation of ZENODO_API_URL an deposition_id to the create_zenodo_deposition_cli utils script to safeguard against URL manipulation.

Tasks

  • Possibly upstream this change as the related code is not open-tyndp specific

Workflow

Open issues

Notes

The following test script was used to verify the implementation:
verify_zenodo_api_validation.py

Generative AI was used to assist with code implementation of this PR. All content has been reviewed, verified, and is the responsibility of the author.

Checklist

  • Security scan(s) show no high-severity bugs, critical vulnerabilities, or exposed secrets.
  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to pixi.toml (using pixi add <dependency-name>).
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Changes in configuration options are added in config/test/*.yaml.
  • The multiple weather/climate years test is passing locally (using pixi run -e open-tyndp tyndp-cyears-test).
  • Open-TYNDP SPDX license header added to all touched files.
  • For new data sources or versions, these instructions have been followed.
  • New rules are documented in the appropriate doc/*.rst files.
  • A release note doc/release_notes.rst is added.
  • Major features are documented with up-to-date information in doc/index.rst.
  • Module docstrings added to new Python scripts.

@daniel-rdt daniel-rdt self-assigned this Jul 3, 2026
@daniel-rdt daniel-rdt added SB Scenario Building CBA Cost Benefit Analysis labels Jul 3, 2026
@daniel-rdt
daniel-rdt marked this pull request as ready for review July 3, 2026 10:36
@daniel-rdt
daniel-rdt requested a review from tgilon July 3, 2026 10:36
@daniel-rdt daniel-rdt changed the title fix: 8 - add validation of Zenodo API URL and deposition_id fix: 11 - add validation of Zenodo API URL and deposition_id Jul 3, 2026

@tgilon tgilon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @daniel-rdt, I think this can be simplified a bit

Comment thread utils/create_zenodo_deposition_cli.py Outdated
@tgilon tgilon added security and removed SB Scenario Building CBA Cost Benefit Analysis labels Jul 6, 2026
@daniel-rdt
daniel-rdt requested a review from tgilon July 7, 2026 09:57
# Conflicts:
#	doc/release_notes.md

@tgilon tgilon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tks @daniel-rdt !

Comment thread doc/release_notes.md Outdated
daniel-rdt and others added 2 commits July 8, 2026 16:57
Co-authored-by: Thomas Gilon <thomas.gilon@openenergytransition.org>
@daniel-rdt
daniel-rdt merged commit 66f91ad into master Jul 8, 2026
7 checks passed
@daniel-rdt
daniel-rdt deleted the fix/security-fix-8 branch July 8, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants