Skip to content

fix: 11 - add validation of Zenodo API URL and deposition_id #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-rdt merged 8 commits into from
Jul 8, 2026
Merged

fix: 11 - add validation of Zenodo API URL and deposition_id #780

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
86fab6c
feat: add validation of Zenodo API URL and deposition_id
daniel-rdt Jul 3, 2026
30c1579
improve wording
daniel-rdt Jul 3, 2026
e937ddf
doc: add release note
daniel-rdt Jul 3, 2026
2e12c7f
Merge branch 'master' into fix/security-fix-8
daniel-rdt Jul 6, 2026
c5c86f7
fix: remove redundant validation of API_URL
daniel-rdt Jul 7, 2026
a84c164
Merge branch 'master' into fix/security-fix-8
daniel-rdt Jul 7, 2026
cdad9e4
Update doc/release_notes.md
daniel-rdt Jul 8, 2026
095aa1e
doc: fix formatting of release note
daniel-rdt Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@

* Add missing regex anchors with `re.fullmatch` to `create_zenodo_deposition_cli` utils script ([778](https://github.com/open-energy-transition/open-tyndp/pull/778)).

* Add validation of Zenodo API base URL and deposition ID in `create_zenodo_deposition_cli` to close URL-manipulation finding ([780](https://github.com/open-energy-transition/open-tyndp/pull/780)).
Comment thread
daniel-rdt marked this conversation as resolved.
Outdated


## Upcoming PyPSA-Eur Release
* Security: SBOM security scan included in CI.
Expand Down
7 changes: 7 additions & 0 deletions utils/create_zenodo_deposition_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,13 @@ def publish_zenodo_deposition(deposition_id: int) -> requests.Response:
Response
The response from the Zenodo API after publishing the deposition.
"""
# Validate id to be positive integer (rejecting bool, int-like strings and traversals)
if (
isinstance(deposition_id, bool)
or not isinstance(deposition_id, int)
or deposition_id <= 0
):
raise ValueError(f"Invalid Zenodo deposition ID: {deposition_id!r}")
r = requests.post(
f"{ZENODO_API_URL}/deposit/depositions/{deposition_id}/actions/publish",
params={"access_token": ZENODO_API_KEY},
Expand Down
Loading