feat: disentangle data/versions.csv using data/tyndp_versions.csv - #788
Merged
Conversation
3 tasks
Conflicts: data/versions.csv doc/release_notes.md
lisazeyen
requested changes
Jul 13, 2026
lisazeyen
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @tgilon for preparing this PR! Looks great, I have two comments concerning the CI and an update of the documentation.
I think the CI is currently failing because the data is not completly sorted in the new tyndp_versions.csv.
Plus I think we should add some more information in the documentation
doc/sb.mdcontains a line "To see which datasets support tyndp-archive, check the source column in data/versions.csv." -> should be changed totyndp_versions.csvdoc/configuration.md("data" config section) should also reference newtyndp_versions-csv, this line needs to be replace See the data/versions.csv file for all available datasets and their sources/versions that are supported.- we could add a reference to the tyndp data version file also here in the docs
Member
Author
Thank you @lisazeyen for the review! I've addressed your comments. RTR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ##773.
Changes proposed in this Pull Request
This PR suggests disentangling the
data/versions.csvfile by introducingdata/tyndp_versions.csv. All the TYNDP-specific version entries, as well as thetyndp-archiveentries, are now tracked in this dedicated file.Follow-up of #787, builds on original PR PyPSA#2016.
Tasks
Workflow
Open issues
Notes
Checklist
Required:
doc/release_notes.md.If applicable:
scripts/lib/validation.config/test/*.yaml.pixi run -e open-tyndp tyndp-cyears-test).doc/*.mdfiles.doc/index.md.