Skip to content

feat: disentangle data/versions.csv using data/tyndp_versions.csv - #788

Merged
lisazeyen merged 6 commits into
masterfrom
feat/773-versions-tyndp
Jul 14, 2026
Merged

feat: disentangle data/versions.csv using data/tyndp_versions.csv#788
lisazeyen merged 6 commits into
masterfrom
feat/773-versions-tyndp

Conversation

@tgilon

@tgilon tgilon commented Jul 8, 2026

Copy link
Copy Markdown
Member

Closes ##773.

Changes proposed in this Pull Request

This PR suggests disentangling the data/versions.csv file by introducing data/tyndp_versions.csv. All the TYNDP-specific version entries, as well as the tyndp-archive entries, are now tracked in this dedicated file.

Follow-up of #787, builds on original PR PyPSA#2016.

Tasks

Workflow

Open issues

Notes

Checklist

Required:

  • Security scans show no high-severity bugs, critical vulnerabilities, or exposed secrets.
  • Changes are tested locally and behave as expected.
  • Code and workflow changes are documented.
  • A release note entry is added to doc/release_notes.md.

If applicable:

  • Changes in configuration options are reflected in scripts/lib/validation.
  • Changes in configuration options are added to config/test/*.yaml.
  • Multiple climate years test passes locally (pixi run -e open-tyndp tyndp-cyears-test).
  • For new data sources or versions, these instructions have been followed.
  • Open-TYNDP SPDX license header is added to all touched files.
  • Module docstrings are added to new Python scripts.
  • New rules are documented in the appropriate doc/*.md files.
  • Major features are documented in doc/index.md.

@tgilon tgilon added this to the Release v0.8 milestone Jul 8, 2026
@tgilon
tgilon requested a review from daniel-rdt July 8, 2026 14:22
@tgilon tgilon self-assigned this Jul 8, 2026
@tgilon tgilon added SB Scenario Building CBA Cost Benefit Analysis labels Jul 8, 2026
@tgilon tgilon linked an issue Jul 8, 2026 that may be closed by this pull request
3 tasks
@tgilon tgilon mentioned this pull request Jul 8, 2026
14 tasks
Conflicts:
	data/versions.csv
	doc/release_notes.md
Base automatically changed from merge-upstream-260706 to master July 10, 2026 09:11
@lisazeyen
lisazeyen requested review from lisazeyen and removed request for daniel-rdt July 10, 2026 10:18

@lisazeyen lisazeyen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tgilon for preparing this PR! Looks great, I have two comments concerning the CI and an update of the documentation.

I think the CI is currently failing because the data is not completly sorted in the new tyndp_versions.csv.

Plus I think we should add some more information in the documentation

  • doc/sb.md contains a line "To see which datasets support tyndp-archive, check the source column in data/versions.csv." -> should be changed to tyndp_versions.csv
  • doc/configuration.md ("data" config section) should also reference new tyndp_versions-csv, this line needs to be replace See the data/versions.csv file for all available datasets and their sources/versions that are supported.
  • we could add a reference to the tyndp data version file also here in the docs

Comment thread data/tyndp_versions.csv Outdated
@tgilon

tgilon commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

Thanks @tgilon for preparing this PR! Looks great, I have two comments concerning the CI and an update of the documentation.

Thank you @lisazeyen for the review! I've addressed your comments. RTR

@lisazeyen lisazeyen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgilon thanks a lot! LGTM!

@lisazeyen
lisazeyen merged commit ab294c3 into master Jul 14, 2026
7 checks passed
@lisazeyen
lisazeyen deleted the feat/773-versions-tyndp branch July 14, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CBA Cost Benefit Analysis SB Scenario Building

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disentangle data/versions.csv using data/tyndp_versions.csv

2 participants