Skip to content

feat: add function to merge low voltage to market node - #790

Merged
lisazeyen merged 8 commits into
masterfrom
feat/722-cba-market-nodes
Jul 28, 2026
Merged

feat: add function to merge low voltage to market node#790
lisazeyen merged 8 commits into
masterfrom
feat/722-cba-market-nodes

Conversation

@lisazeyen

@lisazeyen lisazeyen commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Closes # (if applicable).
#722

Changes proposed in this Pull Request

Merge in the CBA the low voltage nodes and the high voltage nodes to only have market model nodes

Tasks

Workflow

in simplify_sb_network.py a new function is added which attaches all the assets connect to the low voltage buses to the high voltage buses, removes the low voltage load shedding, removes all the links which are connecting then to the same bus in bus0 + bus1 (distribution grid links after the mapping), removes the low votlage buses

Open issues

  • how generic to we need the function. Currently location column is used for the mapping (advantage: very little code to create the busmap, hopefully reusable for H2 Zones) which might fail for other bus carriers (then one would one to define a busmap directly).

Notes

  • one should keep in mind that the added function might be used also for merging the H2 Zones in a later stage, function should be easy to generalise on this use-case.

Checklist

Required:

  • Security scans show no high-severity bugs, critical vulnerabilities, or exposed secrets.
  • Changes are tested locally and behave as expected.
  • Code and workflow changes are documented.
  • A release note entry is added to doc/release_notes.md.
  • The description is human-written and any AI-generated content is marked.

If applicable:
- [ ] Changes in configuration options are reflected in scripts/lib/validation.
- [ ] Changes in configuration options are added to config/test/*.yaml.

  • Multiple climate years test passes locally (pixi run -e open-tyndp tyndp-cyears-test).
    - [ ] For new data sources or versions, these instructions have been followed.
    - [ ] Open-TYNDP SPDX license header is added to all touched files.
  • Module docstrings are added to new Python scripts.
    - [ ] New rules are documented in the appropriate doc/*.md files.
    - [ ] Major features are documented in doc/index.md.

@lisazeyen
lisazeyen requested a review from daniel-rdt July 14, 2026 16:36
@lisazeyen
lisazeyen marked this pull request as ready for review July 15, 2026 06:32
@measrainsey measrainsey linked an issue Jul 23, 2026 that may be closed by this pull request
@lisazeyen lisazeyen self-assigned this Jul 27, 2026

@daniel-rdt daniel-rdt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lisazeyen. I tested the implementation and it looks to be working as intended. The effects are already visible in the required RAM (see test run results here). It is not clear to me yet, how large the performance speed ups of this are, if any.

Otherwise, I have just a couple of comments for the docstring and cleaning up the code a tiny bit.

Comment thread scripts/cba/simplify_sb_network.py Outdated
Comment thread scripts/cba/simplify_sb_network.py Outdated
Comment thread scripts/cba/simplify_sb_network.py Outdated
lisazeyen and others added 4 commits July 28, 2026 13:05
Co-authored-by: Daniel Rüdt <117752024+daniel-rdt@users.noreply.github.com>
Co-authored-by: Daniel Rüdt <117752024+daniel-rdt@users.noreply.github.com>
@lisazeyen
lisazeyen requested a review from daniel-rdt July 28, 2026 12:19
@lisazeyen

Copy link
Copy Markdown
Collaborator Author

thanks @daniel-rdt I applied the suggested changes + added a release note.

@daniel-rdt daniel-rdt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lisazeyen! Looks good to me. Only one minor note to update one of the comments. Then gtg for me :)

Comment thread scripts/cba/simplify_sb_network.py Outdated
Co-authored-by: Daniel Rüdt <117752024+daniel-rdt@users.noreply.github.com>
@lisazeyen
lisazeyen enabled auto-merge (squash) July 28, 2026 13:48
@lisazeyen
lisazeyen merged commit bcd10e3 into master Jul 28, 2026
6 checks passed
@lisazeyen
lisazeyen deleted the feat/722-cba-market-nodes branch July 28, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to CBA to only model market nodes (power sector)

2 participants