feat: add function to merge low voltage to market node - #790
Merged
Conversation
daniel-rdt
requested changes
Jul 28, 2026
daniel-rdt
left a comment
Member
There was a problem hiding this comment.
Thank you @lisazeyen. I tested the implementation and it looks to be working as intended. The effects are already visible in the required RAM (see test run results here). It is not clear to me yet, how large the performance speed ups of this are, if any.
Otherwise, I have just a couple of comments for the docstring and cleaning up the code a tiny bit.
Co-authored-by: Daniel Rüdt <117752024+daniel-rdt@users.noreply.github.com>
Co-authored-by: Daniel Rüdt <117752024+daniel-rdt@users.noreply.github.com>
Collaborator
Author
|
thanks @daniel-rdt I applied the suggested changes + added a release note. |
daniel-rdt
approved these changes
Jul 28, 2026
daniel-rdt
left a comment
Member
There was a problem hiding this comment.
Thank you @lisazeyen! Looks good to me. Only one minor note to update one of the comments. Then gtg for me :)
Co-authored-by: Daniel Rüdt <117752024+daniel-rdt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
#722
Changes proposed in this Pull Request
Merge in the CBA the low voltage nodes and the high voltage nodes to only have market model nodes
Tasks
Workflow
in
simplify_sb_network.pya new function is added which attaches all the assets connect to the low voltage buses to the high voltage buses, removes the low voltage load shedding, removes all the links which are connecting then to the same bus in bus0 + bus1 (distribution grid links after the mapping), removes the low votlage busesOpen issues
locationcolumn is used for the mapping (advantage: very little code to create the busmap, hopefully reusable for H2 Zones) which might fail for other bus carriers (then one would one to define a busmap directly).Notes
Checklist
Required:
doc/release_notes.md.If applicable:
- [ ] Changes in configuration options are reflected inscripts/lib/validation.- [ ] Changes in configuration options are added toconfig/test/*.yaml.pixi run -e open-tyndp tyndp-cyears-test).- [ ] For new data sources or versions, these instructions have been followed.- [ ] Open-TYNDP SPDX license header is added to all touched files.- [ ] New rules are documented in the appropriatedoc/*.mdfiles.- [ ] Major features are documented indoc/index.md.