refactor: fix quoting for clarity - #791
Merged
Merged
Conversation
daniel-rdt
approved these changes
Jul 21, 2026
Member
There was a problem hiding this comment.
Thanks for this. I checked and couldn't find any other instances. Note, there is also no instances where it is the other way around (f'xyz{'abc'}').
I was also only able to find three instances (#1, #2, #3) where the quoting is reversed (i.e. f'abc') and they all come from upstream. All three are queries though, so could also be intentional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #789.
Changes proposed in this Pull Request
This PR suggests changing the quoting patterns for clarity. However, it's legal in Python 3.12+ to reuse the same quote character inside an f-string. Since python 3.12 is implicitly required, this change is not strictly necessary.
This PR relates to PyPSA#2235.
Tasks
Workflow
Open issues
Notes
Checklist
Required:
doc/release_notes.md.If applicable:
scripts/lib/validation.config/test/*.yaml.pixi run -e open-tyndp tyndp-cyears-test).doc/*.mdfiles.doc/index.md.