feat: reduce dependency to upstream retrieves - #798
Merged
Conversation
6 tasks
tgilon
marked this pull request as ready for review
July 21, 2026 09:36
daniel-rdt
requested changes
Jul 24, 2026
daniel-rdt
left a comment
Member
There was a problem hiding this comment.
Thank you @tgilon for this refactoring! This will already improve the dependencies a lot and make our workflow as lean as we can currently make it without many disruptive changes. I have some minor comments and one requested change for the powerplants file in add_electricity.
Co-authored-by: Daniel Rüdt <117752024+daniel-rdt@users.noreply.github.com>
Co-authored-by: Thomas Gilon <thomas.gilon@openenergytransition.org>
daniel-rdt
approved these changes
Jul 29, 2026
daniel-rdt
left a comment
Member
There was a problem hiding this comment.
Thank you @tgilon for the adjustments. This is looking good now and I see that the CI also passes again with your latest fix to the input_gas_network logic 🙌
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #775.
Changes proposed in this Pull Request
This PR suggests reducing dependency to upstream retrieves. To do so, conditional input files are defined in multiple rules.
The following
retrieverules have been removed from the dependencies:The conditional input files also removed the need for the following rules:
Tasks
tyndp-archive(Remove unused dependencies fromtyndp-archive#814)Workflow
Adding more conditional inputs reduces the total number of rules by 103 rules, from 2739 to 2636.
Current PR
Details
On
fix/796-combine-indicatorsDetails
Open issues
The issue #775 also lists other dependencies. These dependencies would require more invasive work, since the files are actually used to build the models.
Notes
Checklist
Required:
doc/release_notes.md.If applicable:
scripts/lib/validation.config/test/*.yaml.pixi run -e open-tyndp tyndp-cyears-test).doc/*.mdfiles.doc/index.md.