fix: use 'overnight' foresight in MSV network preparation

[lisazeyen]

Closes # (if applicable).

Changes proposed in this Pull Request

Changing the foresight from perfect -> overnight in the MSV solve. Perfect should be used only for multiple investment periods (which we do not have in the CBA). Otherwise, additional constraints are added which are not needed for the MSV solve.

Tasks

Workflow

Open issues

Notes

Checklist

Required:

• Security scans show no high-severity bugs, critical vulnerabilities, or exposed secrets.
• Changes are tested locally and behave as expected.
• Code and workflow changes are documented.
• A release note entry is added to doc/release_notes.md.
• The description is human-written and any AI-generated content is marked.

If applicable:
- [ ] Changes in configuration options are reflected in scripts/lib/validation.
- [ ] Changes in configuration options are added to config/test/*.yaml.

• Multiple climate years test passes locally (pixi run -e open-tyndp tyndp-cyears-test).
  - [ ] For new data sources or versions, these instructions have been followed.
  - [ ] Open-TYNDP SPDX license header is added to all touched files.
  - [ ] Module docstrings are added to new Python scripts.
  - [ ] New rules are documented in the appropriate doc/*.md files.
  - [ ] Major features are documented in doc/index.md.

[daniel-rdt]

Thanks @lisazeyen. This is a good catch. This must have gotten confused with the perfect foresight within the year when the CBA MSV was first written.

I would prefer if the PR title, release note (which you will add in the end) and the eventual commit message of the merged PR are clear that the foresight option is only changed for MSV extraction network prep and that the actual solve still has perfect foresight within that one year. Otherwise people might get confused when they read this in the log or release notes.
e.g.:
fix: use 'overnight' foresight in MSV network preparation