fix: use 'overnight' foresight in MSV network preparation - #813
Merged
Conversation
daniel-rdt
reviewed
Jul 29, 2026
daniel-rdt
left a comment
daniel-rdt
left a comment
Member
There was a problem hiding this comment.
Thanks @lisazeyen. This is a good catch. This must have gotten confused with the perfect foresight within the year when the CBA MSV was first written.
I would prefer if the PR title, release note (which you will add in the end) and the eventual commit message of the merged PR are clear that the foresight option is only changed for MSV extraction network prep and that the actual solve still has perfect foresight within that one year. Otherwise people might get confused when they read this in the log or release notes.
e.g.:
fix: use 'overnight' foresight in MSV network preparation
lisazeyen
changed the title
daniel-rdt
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
Changes proposed in this Pull Request
Changing the foresight from
perfect->overnightin the MSV solve. Perfect should be used only for multiple investment periods (which we do not have in the CBA). Otherwise, additional constraints are added which are not needed for the MSV solve.Tasks
Workflow
Open issues
Notes
Checklist
Required:
doc/release_notes.md.If applicable:
- [ ] Changes in configuration options are reflected inscripts/lib/validation.- [ ] Changes in configuration options are added toconfig/test/*.yaml.pixi run -e open-tyndp tyndp-cyears-test).- [ ] For new data sources or versions, these instructions have been followed.- [ ] Open-TYNDP SPDX license header is added to all touched files.- [ ] Module docstrings are added to new Python scripts.- [ ] New rules are documented in the appropriatedoc/*.mdfiles.- [ ] Major features are documented indoc/index.md.