Skip to content

chore: resolve open dependabot security alerts#4

Merged
jonathannorris merged 1 commit into
mainfrom
chore/dependabot-alerts-2
May 25, 2026
Merged

chore: resolve open dependabot security alerts#4
jonathannorris merged 1 commit into
mainfrom
chore/dependabot-alerts-2

Conversation

@jonathannorris
Copy link
Copy Markdown
Member

Summary

  • Added overrides for qs to >=6.15.2 to fix transitive moderate vulnerability (alert #98) — DoS in qs.stringify on null/undefined entries in comma-format arrays. qs comes in transitively via @angular/cli -> @modelcontextprotocol/sdk -> express/body-parser and via karma -> body-parser.

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
@jonathannorris jonathannorris requested a review from Copilot May 25, 2026 14:09
@jonathannorris jonathannorris marked this pull request as ready for review May 25, 2026 14:09
@jonathannorris jonathannorris merged commit b7d08d3 into main May 25, 2026
1 of 2 checks passed
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the qs dependency to version 6.15.2 and introduces a version override in package.json to address security vulnerabilities. The reviewer suggests using a caret range (^6.15.2) instead of >=6.15.2 for the override to prevent potential breaking changes from future major version upgrades while still receiving security patches and minor updates.

Comment thread package.json
"typescript": "~5.9.0"
},
"overrides": {
"qs": ">=6.15.2"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using >=6.15.2 for the override is effective for resolving the security alert, but it allows for potential automatic upgrades to future major versions (e.g., 7.0.0). Since qs major versions often include breaking changes in how query strings are parsed or stringified, it is safer to use a caret range like ^6.15.2. This ensures you get security patches and minor updates within the version 6 ecosystem while maintaining API compatibility.

Suggested change
"qs": ">=6.15.2"
"qs": "^6.15.2"

@jonathannorris jonathannorris review requested due to automatic review settings May 25, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant