Skip to content

Add postUpdateOptions for gomodTidy#120

Open
beeme1mr wants to merge 1 commit intomainfrom
beeme1mr-patch-1
Open

Add postUpdateOptions for gomodTidy#120
beeme1mr wants to merge 1 commit intomainfrom
beeme1mr-patch-1

Conversation

@beeme1mr
Copy link
Copy Markdown
Member

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the postUpdateOptions configuration to default.json to automate go mod tidy. However, feedback indicates that this setting is restricted in Renovate presets and will likely be ignored for security reasons, suggesting it should be moved to a local or organization-level configuration instead.

Comment thread default.json
"semanticCommitScope": "security",
"commitMessageSuffix": "[SECURITY]"
},
"postUpdateOptions": ["gomodTidy"],
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The postUpdateOptions setting is a restricted configuration option in Renovate. According to the Renovate documentation, this option cannot be defined in presets (which default.json typically is) and will be ignored for security reasons unless the preset is explicitly marked as 'trusted' by the Renovate runner. If the intention is for this to apply to all repositories extending this configuration, it should instead be defined in each repository's local configuration or in a global/organization-level configuration that has the necessary permissions.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. I have personally used this option in a preset as recently as today.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the rest look good? It seems safe to try out.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants