Fixed tests for evaluator

[m-olko]

This PR

Due to evaluator and flag configuration validator were developed on different branches without any conflicts, the tests broke when both got merged to main. This PR contains minor fixes for them to work correctly.

How to test

gbazelisk test //providers/flagd/tests:evaluator_test

[gemini-code-assist]

Summary of Changes

Hello @m-olko, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses several test failures that emerged after the integration of the flag evaluator and flag configuration validator features. The changes primarily involve refining the flag evaluation logic to correctly handle missing configurations and updating test utilities to reflect current data structures, thereby restoring the integrity of the test suite.

Highlights

• Evaluator Logic Correction: Corrected a logical error in the JsonLogicEvaluator::ResolveAny method, inverting a null check condition to properly handle scenarios where flag configurations are not available, ensuring an appropriate error is returned.
• Test Utility Update: Modified the TestableSync::TriggerUpdate method in the test suite to pass the entire JSON object to UpdateFlags, aligning with the expected input format for flag configuration updates.
• Test Assertion Refinement: Removed a specific error message assertion from the ResolveBoolean_VariantNotFound test, making the test more robust to potential changes in error message strings while still validating the core error code and reason.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses broken tests for the evaluator by introducing a few necessary fixes. The change in evaluator.cpp correctly inverts a condition to handle cases where flags are not available. The test suite is also updated to align with the validation logic and to correct an assertion. The suggestion to enhance a test by updating an error message check rather than removing it has been retained, as it aligns with best practices for robust testing.