-
Notifications
You must be signed in to change notification settings - Fork 2
Global and Client API #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a30fa81
Draft PR
NeaguGeorgiana23 8b72855
Draft 2
NeaguGeorgiana23 aac3c5f
final
NeaguGeorgiana23 d00639e
Merge branch 'main' of https://github.com/open-feature/cpp-sdk into g…
NeaguGeorgiana23 fd9d8a0
update bazel
NeaguGeorgiana23 875c7a1
fix linter error
NeaguGeorgiana23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 7.4.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| #include "client_api.h" | ||
|
|
||
| #include <utility> | ||
|
|
||
| #include "openfeature/flag_metadata.h" | ||
| #include "openfeature/global_context_manager.h" | ||
| #include "openfeature/reason.h" | ||
|
|
||
| namespace openfeature { | ||
|
|
||
| ClientAPI::ClientAPI(ProviderRepository& repository, std::string_view domain) | ||
| : provider_repository_(repository), domain_(domain) {} | ||
|
|
||
| Metadata ClientAPI::GetMetadata() { return Metadata{domain_}; } | ||
|
|
||
| EvaluationContext ClientAPI::GetEvaluationContext() { | ||
| std::lock_guard<std::mutex> lock(context_mutex_); | ||
| return evaluation_context_; | ||
| } | ||
|
|
||
| void ClientAPI::SetEvaluationContext(const EvaluationContext& ctx) { | ||
| std::lock_guard<std::mutex> lock(context_mutex_); | ||
| evaluation_context_ = ctx; | ||
| } | ||
|
|
||
| ProviderStatus ClientAPI::GetProviderStatus() { | ||
| return provider_repository_.GetProviderStatus(domain_); | ||
| } | ||
|
|
||
| bool ClientAPI::GetBooleanValue(std::string_view flag_key, bool default_value) { | ||
| return EvaluateBooleanFlag(flag_key, default_value, std::nullopt)->GetValue(); | ||
| } | ||
|
|
||
| bool ClientAPI::GetBooleanValue(std::string_view flag_key, bool default_value, | ||
| const EvaluationContext& ctx) { | ||
| return EvaluateBooleanFlag(flag_key, default_value, ctx)->GetValue(); | ||
| } | ||
|
|
||
| std::unique_ptr<BoolResolutionDetails> ClientAPI::EvaluateBooleanFlag( | ||
| std::string_view flag_key, bool default_value, | ||
| const std::optional<EvaluationContext>& ctx) { | ||
| if (GetProviderStatus() != ProviderStatus::kReady) { | ||
| return std::make_unique<BoolResolutionDetails>( | ||
| default_value, Reason::kError, std::nullopt, FlagMetadata(), | ||
| ErrorCode::kProviderNotReady, "Provider is not ready"); | ||
| } | ||
|
|
||
| std::shared_ptr<FeatureProvider> provider = | ||
| provider_repository_.GetProvider(domain_); | ||
| if (!provider) { | ||
| return std::make_unique<BoolResolutionDetails>( | ||
| default_value, Reason::kError, std::nullopt, FlagMetadata(), | ||
| ErrorCode::kProviderFatal, "Provider not found for domain"); | ||
| } | ||
|
|
||
| EvaluationContext merged_context = MergeContexts(ctx); | ||
| return provider->GetBooleanEvaluation(flag_key, default_value, | ||
| merged_context); | ||
| } | ||
|
|
||
| EvaluationContext ClientAPI::MergeContexts( | ||
| const std::optional<EvaluationContext>& invocation_ctx) { | ||
| // TODO: Add context merging logic after EvaluationContext is implemented. | ||
|
|
||
| if (invocation_ctx) { | ||
| return *invocation_ctx; | ||
| } | ||
| return GetEvaluationContext(); | ||
| } | ||
|
|
||
| } // namespace openfeature | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| #ifndef CPP_SDK_INCLUDE_OPENFEATURE_CLIENT_API_H_ | ||
| #define CPP_SDK_INCLUDE_OPENFEATURE_CLIENT_API_H_ | ||
|
|
||
| #include <memory> | ||
| #include <mutex> | ||
| #include <optional> | ||
| #include <string> | ||
| #include <string_view> | ||
|
|
||
| #include "openfeature/client.h" | ||
| #include "openfeature/evaluation_context.h" | ||
| #include "openfeature/features.h" | ||
| #include "openfeature/global_context_manager.h" | ||
| #include "openfeature/metadata.h" | ||
| #include "openfeature/provider.h" | ||
| #include "openfeature/provider_repository.h" | ||
| #include "openfeature/provider_status.h" | ||
| #include "openfeature/resolution_details.h" | ||
|
|
||
| namespace openfeature { | ||
|
|
||
| // OpenFeature client implementation. | ||
| class ClientAPI : public Client { | ||
| public: | ||
| ClientAPI(ProviderRepository& repository, std::string_view domain); | ||
|
|
||
| ~ClientAPI() override = default; | ||
|
|
||
| ClientAPI(const ClientAPI&) = delete; | ||
| ClientAPI& operator=(const ClientAPI&) = delete; | ||
|
|
||
| Metadata GetMetadata() override; | ||
|
|
||
| // Return an optional client-level evaluation context. | ||
| EvaluationContext GetEvaluationContext() override; | ||
|
|
||
| // Set the client-level evaluation context. | ||
| void SetEvaluationContext(const EvaluationContext& ctx) override; | ||
|
|
||
| // Returns the current status of the associated provider. | ||
| ProviderStatus GetProviderStatus() override; | ||
|
|
||
| bool GetBooleanValue(std::string_view flag_key, bool default_value) override; | ||
| bool GetBooleanValue(std::string_view flag_key, bool default_value, | ||
| const EvaluationContext& ctx) override; | ||
|
|
||
| // TODO: Add methods to get and set Hooks. | ||
| // TODO: Add methods for flag evaluation for other types (e.g. string, int, | ||
| // float, object). | ||
| // TODO: Add methods for detailed flag evaluation. | ||
| // TODO: Overload method "GetBooleanValue" to accept "Evaluation Options". | ||
|
|
||
| private: | ||
| std::unique_ptr<BoolResolutionDetails> EvaluateBooleanFlag( | ||
| std::string_view flag_key, bool default_value, | ||
| const std::optional<EvaluationContext>& ctx); | ||
|
|
||
| EvaluationContext MergeContexts( | ||
| const std::optional<EvaluationContext>& invocation_ctx); | ||
|
|
||
| ProviderRepository& provider_repository_; | ||
| std::string domain_; | ||
| EvaluationContext evaluation_context_; | ||
| mutable std::mutex context_mutex_; | ||
| }; | ||
|
|
||
| } // namespace openfeature | ||
|
|
||
| #endif // CPP_SDK_INCLUDE_OPENFEATURE_CLIENT_API_H_ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| #include "openfeature/global_context_manager.h" | ||
|
|
||
| #include <mutex> | ||
|
|
||
| namespace openfeature { | ||
|
|
||
| GlobalContextManager& GlobalContextManager::GetInstance() { | ||
| static GlobalContextManager instance; | ||
| return instance; | ||
| } | ||
|
|
||
| void GlobalContextManager::SetGlobalEvaluationContext( | ||
| const EvaluationContext& ctx) { | ||
| std::unique_lock<std::shared_mutex> lock(context_mutex_); | ||
| global_evaluation_context_ = ctx; | ||
| } | ||
|
|
||
| EvaluationContext GlobalContextManager::GetGlobalEvaluationContext() const { | ||
| std::shared_lock<std::shared_mutex> lock(context_mutex_); | ||
| return global_evaluation_context_; | ||
| } | ||
|
|
||
| } // namespace openfeature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| #ifndef CPP_SDK_INCLUDE_OPENFEATURE_GLOBAL_CONTEXT_MANAGER_H_ | ||
| #define CPP_SDK_INCLUDE_OPENFEATURE_GLOBAL_CONTEXT_MANAGER_H_ | ||
|
|
||
| #include <memory> | ||
| #include <shared_mutex> | ||
|
|
||
| #include "openfeature/evaluation_context.h" | ||
|
|
||
| namespace openfeature { | ||
|
|
||
| // Manages the global Evaluation Context for the OpenFeature SDK. | ||
| // This data is static across the application (unless explicitly changed) | ||
| class GlobalContextManager { | ||
| public: | ||
| static GlobalContextManager& GetInstance(); | ||
|
|
||
| GlobalContextManager(const GlobalContextManager&) = delete; | ||
| GlobalContextManager& operator=(const GlobalContextManager&) = delete; | ||
|
|
||
| // Updates the global evaluation context. | ||
| void SetGlobalEvaluationContext(const EvaluationContext& ctx); | ||
|
|
||
| // Retrieves the current global evaluation context. | ||
| EvaluationContext GetGlobalEvaluationContext() const; | ||
|
|
||
| private: | ||
| GlobalContextManager() = default; | ||
| EvaluationContext global_evaluation_context_; | ||
| mutable std::shared_mutex context_mutex_; | ||
| }; | ||
|
|
||
| } // namespace openfeature | ||
|
|
||
| #endif // CPP_SDK_INCLUDE_OPENFEATURE_GLOBAL_CONTEXT_MANAGER_H_ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.