-
Notifications
You must be signed in to change notification settings - Fork 43
feat: Update Target Framework to include net10.0 #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: André Silva <[email protected]>
Signed-off-by: André Silva <[email protected]>
Summary of ChangesHello @askpt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the target frameworks for the projects to include .NET 10.0, and also adds multi-targeting for several other frameworks like .NET 9.0, .NET 8.0, and .NET 4.62. The changes in the project files are mostly correct, but I've suggested a more robust way to conditionally define the target frameworks in the test projects to improve maintainability.
Signed-off-by: André Silva [email protected]
This PR
This pull request updates the target frameworks for both the main
OpenFeature.Contrib.Providers.Flagdlibrary and its related test projects. The primary goal is to add support for newer .NET versions, ensuring compatibility with future .NET releases, while maintaining backward compatibility with older frameworks.Target framework updates:
OpenFeature.Contrib.Providers.Flagd.csproj) to targetnetstandard2.0,net462,net8.0,net9.0, andnet10.0, expanding compatibility across multiple .NET versions.OpenFeature.Contrib.Providers.Flagd.E2e.Common.csprojandOpenFeature.Contrib.Providers.Flagd.Test.csproj) to targetnet8.0,net9.0, andnet10.0by default, and conditionally includenet462when running on Windows, ensuring tests can run across both legacy and latest .NET environments. [1] [2]Related Issues
Fixes #510