Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,11 @@ private ResolutionDetails<T> ResolveValue<T>(string flagKey, T defaultValue,
flagMetadata: flagMetadata
);
}
else
{
throw new FeatureProviderException(ErrorType.General,
$"TARGETING_MATCH_ERROR: flag '{flagKey}' targeting resolved to variant '{variant}', but it could not be found.");
}
}

throw new FeatureProviderException(ErrorType.FlagNotFound,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,45 @@ public void TestJsonEvaluatorFlagWithInvalidVariantReturnsParseError()
.Build();

// Act & Assert
Assert.Throws<FeatureProviderException>(() => this._jsonEvaluator.ResolveStringValueAsync("error-targeting-flag", "one", context));
var ex = Assert.Throws<FeatureProviderException>(() => this._jsonEvaluator.ResolveStringValueAsync("error-targeting-flag", "one", context));

Assert.Equal(ErrorType.ParseError, ex.ErrorType);
Assert.Equal("PARSE_ERROR: flag 'error-targeting-flag' has invalid targeting rule.", ex.Message);
}

[Fact]
public void TestJsonEvaluatorFlagWithMissingVariantReturnsGeneralError()
{
// Arrange
var flag = //lang=json
"""
{
"flags": {
"missing-variant-targeting-flag": {
"state": "ENABLED",
"variants": {
"one": 1,
"two": 2
},
"defaultVariant": "two",
"targeting": {
"if": [true, "three", "one"]
}
}
}
}
""";

this._jsonEvaluator.Sync(FlagConfigurationUpdateType.ALL, flag);

var context = EvaluationContext.Builder()
.SetTargetingKey("three")
.Build();

// Act & Assert
var ex = Assert.Throws<FeatureProviderException>(() => this._jsonEvaluator.ResolveIntegerValueAsync("missing-variant-targeting-flag", 3, context));

Assert.Equal(ErrorType.General, ex.ErrorType);
Assert.Equal("TARGETING_MATCH_ERROR: flag 'missing-variant-targeting-flag' targeting resolved to variant 'three', but it could not be found.", ex.Message);
}
}
Loading